From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval
Date: Wed, 10 Mar 2021 12:19:47 +0100 [thread overview]
Message-ID: <2ddefdf1-b6e8-9c23-caef-aa7de1c58005@proxmox.com> (raw)
In-Reply-To: <20210310091047.16557-2-d.csapak@proxmox.com>
On 10.03.21 10:10, Dominik Csapak wrote:
> from 2 to 60 seconds. To retain the response time of the gui
> when adding/editing/removing, trigger a manual reload on these actions
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Please add my Suggested-by or Reported-by tags for reference the next time,
thanks!
> ---
> www/NavigationTree.js | 11 ++++++++++-
> www/tape/ChangerConfig.js | 6 ++++++
> www/tape/DriveConfig.js | 6 ++++++
> 3 files changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/www/NavigationTree.js b/www/NavigationTree.js
> index 4bdfbc66..6d288f09 100644
> --- a/www/NavigationTree.js
> +++ b/www/NavigationTree.js
> @@ -122,7 +122,7 @@ Ext.define('PBS.view.main.NavigationTree', {
> if (view.tapestore === undefined) {
> view.tapestore = Ext.create('Proxmox.data.UpdateStore', {
> autoStart: true,
> - interval: 2 * 1000,
> + interval: 60 * 1000,
> storeid: 'pbs-tape-drive-list',
> model: 'pbs-tape-drive-list',
> });
> @@ -269,6 +269,15 @@ Ext.define('PBS.view.main.NavigationTree', {
> },
> },
>
> + reloadTapeStore: function() {
> + let me = this;
> + if (!PBS.enableTapeUI) {
> + return;
> + }
> +
> + me.tapestore.load();
> + },
> +
> select: function(path, silent) {
> var me = this;
> if (me.rstore.isLoaded() && (!PBS.enableTapeUI || me.tapestore.isLoaded())) {
> diff --git a/www/tape/ChangerConfig.js b/www/tape/ChangerConfig.js
> index 1646ddef..1c048b23 100644
> --- a/www/tape/ChangerConfig.js
> +++ b/www/tape/ChangerConfig.js
> @@ -11,6 +11,11 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
> controller: {
> xclass: 'Ext.app.ViewController',
>
> + reloadTapeStore: function() {
> + let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> + navtree.reloadTapeStore();
> + },
> +
> onAdd: function() {
> let me = this;
> Ext.create('PBS.TapeManagement.ChangerEditWindow', {
> @@ -40,6 +45,7 @@ Ext.define('PBS.TapeManagement.ChangerPanel', {
>
> reload: function() {
> this.getView().getStore().rstore.load();
> + this.reloadTapeStore();
> },
>
> stopStore: function() {
> diff --git a/www/tape/DriveConfig.js b/www/tape/DriveConfig.js
> index 763f8e55..40d4b2a9 100644
> --- a/www/tape/DriveConfig.js
> +++ b/www/tape/DriveConfig.js
> @@ -19,6 +19,11 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
> controller: {
> xclass: 'Ext.app.ViewController',
>
> + reloadTapeStore: function() {
> + let navtree = Ext.ComponentQuery.query('navigationtree')[0];
> + navtree.reloadTapeStore();
> + },
> +
> onAdd: function() {
> let me = this;
> Ext.create('PBS.TapeManagement.DriveEditWindow', {
> @@ -57,6 +62,7 @@ Ext.define('PBS.TapeManagement.DrivePanel', {
>
> reload: function() {
> this.getView().getStore().rstore.load();
> + this.reloadTapeStore();
> },
>
> stopStore: function() {
>
next prev parent reply other threads:[~2021-03-10 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:10 [pbs-devel] [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating Dominik Csapak
2021-03-10 9:10 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: tape: increase tapestore interval Dominik Csapak
2021-03-10 11:19 ` Thomas Lamprecht [this message]
2021-03-10 11:38 ` Dominik Csapak
2021-03-10 11:47 ` Thomas Lamprecht
2021-03-10 12:32 ` Dominik Csapak
2021-03-10 12:41 ` Thomas Lamprecht
2021-03-10 10:01 ` [pbs-devel] applied: [PATCH proxmox-backup 1/2] ui: NavigationTree: do not modify list while iterating Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ddefdf1-b6e8-9c23-caef-aa7de1c58005@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal