From: Filip Schauer <f.schauer@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox 1/1] fix #4995: compression: Include symlinks in zip file restore
Date: Thu, 14 Dec 2023 15:50:19 +0100 [thread overview]
Message-ID: <2d73c2db-5f2b-4a3f-85a9-7b7c5f7c2eed@proxmox.com> (raw)
In-Reply-To: <9efec590-7ab0-4108-b321-896f069f7929@proxmox.com>
Patch v3 available:
https://lists.proxmox.com/pipermail/pbs-devel/2023-December/007538.html
On 24/11/2023 12:03, Lukas Wagner wrote:
> On 11/24/23 08:56, Dominik Csapak wrote:
>> * if you want to go the extra mile, i guess this would be a good time
>> to add tests
>> that create a new zip from test data, to see if they don't break
>> with your changes
>>
>
> I agree!
>
> I think writing tests for changes should be the default and not be
> considered as 'the extra mile' - especially considering that it should
> be relatively easy to write tests for this crate (no weird
> dependencies, no need to run as a certain user, etc.)
>
next prev parent reply other threads:[~2023-12-14 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 13:06 [pbs-devel] [PATCH v2 many] fix #4995: " Filip Schauer
2023-11-23 13:06 ` [pbs-devel] [PATCH v2 proxmox 1/1] fix #4995: compression: " Filip Schauer
2023-11-24 7:56 ` Dominik Csapak
2023-11-24 11:03 ` Lukas Wagner
2023-12-14 14:50 ` Filip Schauer [this message]
2023-11-23 13:06 ` [pbs-devel] [PATCH v2 backup 1/1] fix #4995: pxar: " Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d73c2db-5f2b-4a3f-85a9-7b7c5f7c2eed@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal