From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v5 1/2] router: cli: added `ask_for_confirmation` helper
Date: Thu, 25 Apr 2024 13:32:33 +0200 [thread overview]
Message-ID: <2d3e9529-c5c7-451c-a83e-a242fbc1aa65@proxmox.com> (raw)
In-Reply-To: <D0T4Z7GOJWRH.1E15N94N7EKZL@proxmox.com>
Am 25/04/2024 um 12:37 schrieb Gabriel Goller:
> anyhow is already used in proxmox-router so I'd say we can just as well
> use it. A simple bail! with the message you proposed should do the trick:
>
> Abort – unexpected choice "no"! Use enter for default or use 'y' or 'n'.
I'd drop the "Abort -" here and bail only with the "unexpected choice "{input}"!
Use enter for default or use 'y' or 'n'" here, as what the calling code then
does is their decision, might not necessarily be aborting the current operation,
but re-asking the user again.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-25 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 11:49 [pbs-devel] [PATCH proxmox{, -backup} v5 0/2] close #4763: client: added command to forget backup group Gabriel Goller
2024-04-18 11:49 ` [pbs-devel] [PATCH proxmox v5 1/2] router: cli: added `ask_for_confirmation` helper Gabriel Goller
2024-04-24 19:03 ` Thomas Lamprecht
2024-04-25 8:52 ` Gabriel Goller
2024-04-25 9:42 ` Thomas Lamprecht
2024-04-25 10:37 ` Gabriel Goller
2024-04-25 11:32 ` Thomas Lamprecht [this message]
2024-04-18 11:49 ` [pbs-devel] [PATCH proxmox-backup v5 2/2] close #4763: client: add command to forget backup group Gabriel Goller
2024-04-26 12:37 ` [pbs-devel] [PATCH proxmox{, -backup} v5 0/2] close #4763: client: added " Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d3e9529-c5c7-451c-a83e-a242fbc1aa65@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal