From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] QEMU AMD SEV enable
Date: Tue, 8 Nov 2022 17:54:54 +0100 [thread overview]
Message-ID: <2ce86d4e-4674-193a-b7aa-aa99eaa55ca6@proxmox.com> (raw)
In-Reply-To: <e9a5082f-aa47-e521-66ec-e441ec9a24df@proxmox.com>
Am 02/09/2022 um 13:24 schrieb Daniel Tschlatscher:
> Tested-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
>
thx!
>
> Some more comments inline in the code, all of which are non-breaking though:
@Markus, Daniels comment seem all reasonable and not only cosmetic (e.g.,
the typo in the schema for "minimum") can you please send a v2 with those
addressed, maybe also include a new docs patch with the respective comments
there either addressed, if sensible - thx!
prev parent reply other threads:[~2022-11-08 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 11:14 Markus Frank
2022-06-09 11:14 ` [pve-devel] [PATCH pve-docs] added Memory Encryption documentation Markus Frank
2022-09-02 11:24 ` [pve-devel] [PATCH qemu-server] QEMU AMD SEV enable Daniel Tschlatscher
2022-11-08 16:54 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ce86d4e-4674-193a-b7aa-aa99eaa55ca6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.