From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH pve_flutter_frontend v2] ui: replace deprecated `onBackground` property
Date: Tue, 1 Jul 2025 13:55:15 +0200 [thread overview]
Message-ID: <2c5ca585-057c-4bc7-9b2e-c45cf99dcf49@proxmox.com> (raw)
In-Reply-To: <20250605082322.57783-1-s.shaji@proxmox.com>
On 6/5/25 10:23, Shan Shaji wrote:
> As of flutter v3.22, the `onBackground` property is deprecated. The
> material guidelines suggest using the `onSurface` property instead.
>
> https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585
>
> For dark theme, the `onSurface` color and `onBackground` color is
> different so it's not possible to directly replace the `onBackground`
> with the `onSurface` property.To fix the issue, add a new
> `onSurfaceVariant` property to the theme and replace all
> instances of `onBackground` with `onSurfaceVariant`.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>
> changes since v1:
> * rebased branch with the changes from master.
>
> lib/main.dart | 4 ++--
> lib/widgets/proxmox_capacity_indicator.dart | 8 +++++---
> lib/widgets/pve_file_selector_widget.dart | 14 +++++++++-----
> lib/widgets/pve_lxc_overview.dart | 2 +-
> lib/widgets/pve_qemu_overview.dart | 5 +++--
> lib/widgets/pve_task_log_expansiontile_widget.dart | 2 +-
> 6 files changed, 21 insertions(+), 14 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-01 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 8:23 [pve-devel] " Shan Shaji
2025-07-01 11:55 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c5ca585-057c-4bc7-9b2e-c45cf99dcf49@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.