* [pve-devel] [PATCH widget-toolkit] RDD: don't display power-of-two suffix 'i' for values without unit suffix
@ 2022-10-10 9:55 Matthias Heiserer
2022-11-16 19:35 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Matthias Heiserer @ 2022-10-10 9:55 UTC (permalink / raw)
To: pve-devel
So instead of showing "0 i" (meaning e.g. 0 Gi), just display "0".
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
I couldn't come up with a shorter commit message, feel free to change it.
src/panel/RRDChart.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
index 41533ea..263070a 100644
--- a/src/panel/RRDChart.js
+++ b/src/panel/RRDChart.js
@@ -92,7 +92,7 @@ Ext.define('Proxmox.widget.RRDChart', {
value = Ext.util.Format.number(value, format);
let unit = units[si];
- if (this.powerOfTwo) unit += 'i';
+ if (unit && this.powerOfTwo) unit += 'i';
return `${value.toString()} ${unit}`;
},
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH widget-toolkit] RDD: don't display power-of-two suffix 'i' for values without unit suffix
2022-10-10 9:55 [pve-devel] [PATCH widget-toolkit] RDD: don't display power-of-two suffix 'i' for values without unit suffix Matthias Heiserer
@ 2022-11-16 19:35 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-16 19:35 UTC (permalink / raw)
To: Proxmox VE development discussion, Matthias Heiserer
Am 10/10/2022 um 11:55 schrieb Matthias Heiserer:
> So instead of showing "0 i" (meaning e.g. 0 Gi), just display "0".
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>
> I couldn't come up with a shorter commit message, feel free to change it.
>
> src/panel/RRDChart.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-16 19:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 9:55 [pve-devel] [PATCH widget-toolkit] RDD: don't display power-of-two suffix 'i' for values without unit suffix Matthias Heiserer
2022-11-16 19:35 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal