From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH pve-flutter-frontend v2] node overview: add power settings menu
Date: Wed, 17 Apr 2024 10:48:04 +0200 [thread overview]
Message-ID: <2c48cdac-4dbd-471f-865c-27f290aa4118@proxmox.com> (raw)
In-Reply-To: <20240417064546.271430-1-d.csapak@proxmox.com>
Am 17/04/2024 um 08:45 schrieb Dominik Csapak:
> similar to how it works for qemu, but add a confirmation dialog
> so one does not accidentally shutdown or reboot a node.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * add an AlertDialog as confirmation before executing the action
>
> lib/bloc/pve_node_overview_bloc.dart | 11 +++
> lib/widgets/pve_node_overview.dart | 24 ++++++
> .../pve_node_power_settings_widget.dart | 84 +++++++++++++++++++
> 3 files changed, 119 insertions(+)
> create mode 100644 lib/widgets/pve_node_power_settings_widget.dart
>
>
applied this already a bit ago [0] with some code style follow-up [1], so
can you please send the changes to adapt to Folke's review as patch on-top
of current master?
[0]: https://git.proxmox.com/?p=flutter/pve_flutter_frontend.git;a=commitdiff;h=16ddf759f338e59501520068867624b549215553
[1]: https://git.proxmox.com/?p=flutter/pve_flutter_frontend.git;a=commitdiff;h=e883ee3b9c9c7c6cee85d5ac77dcc86dbf7c12c0
prev parent reply other threads:[~2024-04-17 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 6:45 [pve-devel] " Dominik Csapak
2024-04-17 8:19 ` Folke Gleumes
2024-04-17 8:33 ` Dominik Csapak
2024-04-17 8:48 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c48cdac-4dbd-471f-865c-27f290aa4118@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.