Re: [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints

From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>,
	pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints
Date: Mon, 22 Jul 2024 14:29:51 +0200	[thread overview]
Message-ID: <2c2954eb-ef8a-4d68-bb85-5d0738241c20@proxmox.com> (raw)
In-Reply-To: <94034b20-ccbc-4369-bf37-0d41ac17883c@proxmox.com>

On  2024-07-22 14:10, Stefan Hanreich wrote:
> I got the following JS error when trying to save a secret/header/body
> template with the content: `qweqwe   ßẞuuuu`
> 
> Uncaught DOMException: String contains an invalid character
>     getValue https://10.101.110.1:8007/widgettoolkit/proxmoxlib.js:11924
>     each ExtJS
>     getValue https://10.101.110.1:8007/widgettoolkit/proxmoxlib.js:11920
>     checkChange ExtJS
>     itemChange https://10.101.110.1:8007/widgettoolkit/proxmoxlib.js:12009
>     ExtJS 22
> proxmoxlib.js:11924
> 
> 
> Seems like the issue is with btoa and uppercase scharfes S?
> When using Umlauts, I at least get an error message, but cannot save.
> 
> 
> Other than that everything worked fine - consider this:
> Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>
> 

Thanks a lot for testing, Stefan.

Indeed it looks like btoa has problems with unicode characters.
Luckily, MDN [1] has got our back with that one. I'll use that workaround
in an upcoming v3.

[1] https://developer.mozilla.org/en-US/docs/Glossary/Base64#the_unicode_problem

-- 
- Lukas

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel