[pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Alexandre Derumier]

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
---
 src/PVE/Network/SDN/Zones/VlanPlugin.pm            | 3 +++
 src/test/zones/vlan/bridge/expected_sdn_interfaces | 4 ++++
 src/test/zones/vlan/bridge/sdn_config              | 2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/PVE/Network/SDN/Zones/VlanPlugin.pm b/src/PVE/Network/SDN/Zones/VlanPlugin.pm
index 6a68e8d..13fb49e 100644
--- a/src/PVE/Network/SDN/Zones/VlanPlugin.pm
+++ b/src/PVE/Network/SDN/Zones/VlanPlugin.pm
@@ -106,17 +106,20 @@ sub generate_sdn_config {
 	@iface_config = ();
 	push @iface_config, "link-type veth";
 	push @iface_config, "veth-peer-name $vnet_uplinkpeer";
+	push @iface_config, "mtu $mtu" if $mtu;
 	push(@{$config->{$vnet_uplink}}, @iface_config) if !$config->{$vnet_uplink};
 
 	@iface_config = ();
 	push @iface_config, "link-type veth";
 	push @iface_config, "veth-peer-name $vnet_uplink";
+	push @iface_config, "mtu $mtu" if $mtu;
 	push(@{$config->{$vnet_uplinkpeer}}, @iface_config) if !$config->{$vnet_uplinkpeer};
 
 	@iface_config = ();
 	push @iface_config, "bridge_ports $bridge_ports $vnet_uplinkpeer";
 	push @iface_config, "bridge_stp off";
 	push @iface_config, "bridge_fd 0";
+	push @iface_config, "mtu $mtu" if $mtu;
 	push(@{$config->{$bridgevlan}}, @iface_config) if !$config->{$bridgevlan};
     }
 
diff --git a/src/test/zones/vlan/bridge/expected_sdn_interfaces b/src/test/zones/vlan/bridge/expected_sdn_interfaces
index f9e96d1..fc05ff7 100644
--- a/src/test/zones/vlan/bridge/expected_sdn_interfaces
+++ b/src/test/zones/vlan/bridge/expected_sdn_interfaces
@@ -4,20 +4,24 @@ auto ln_myvnet
 iface ln_myvnet
 	link-type veth
 	veth-peer-name pr_myvnet
+	mtu 9200
 
 auto myvnet
 iface myvnet
 	bridge_ports ln_myvnet
 	bridge_stp off
 	bridge_fd 0
+	mtu 9200
 
 auto pr_myvnet
 iface pr_myvnet
 	link-type veth
 	veth-peer-name ln_myvnet
+	mtu 9200
 
 auto vmbr0v100
 iface vmbr0v100
 	bridge_ports  eth0.100 pr_myvnet
 	bridge_stp off
 	bridge_fd 0
+	mtu 9200
diff --git a/src/test/zones/vlan/bridge/sdn_config b/src/test/zones/vlan/bridge/sdn_config
index c6cfaaa..c61e659 100644
--- a/src/test/zones/vlan/bridge/sdn_config
+++ b/src/test/zones/vlan/bridge/sdn_config
@@ -6,6 +6,6 @@
                       },
              },
   zones   => {
-               ids => { myzone => { bridge => "vmbr0", ipam => "pve", type => "vlan" } },
+               ids => { myzone => { bridge => "vmbr0", ipam => "pve", type => "vlan", mtu => "9200" } },
              },
 }
-- 
2.39.2

Re: [pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Stefan Hanreich]

I've tested this on my machine. It works if the MTU is explicitly set in
the zone configuration. If the MTU is set on the bridge to something
else than 1500 and the zone configuration has 'auto', then the MTU of
all other interfaces and bridges is still set to 1500.

Shouldn't we try to get the MTU of the bridge when it's set to 'auto'
and then setup the other interfaces accordingly? Or am I
misunderstanding what 'auto' does?

Re: [pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Stefan Hanreich]

On 4/4/24 15:58, Stefan Hanreich wrote:
> I've tested this on my machine. It works if the MTU is explicitly set in
> the zone configuration. If the MTU is set on the bridge to something
> else than 1500 and the zone configuration has 'auto', then the MTU of
> all other interfaces and bridges is still set to 1500.
> 
> Shouldn't we try to get the MTU of the bridge when it's set to 'auto'
> and then setup the other interfaces accordingly? Or am I
> misunderstanding what 'auto' does?

While this is still an issue, it at least makes the MTU work if it is
explicitly set, we can add the functionality for auto in a subsequent patch.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Thomas Lamprecht]

Am 15.11.24 um 14:44 schrieb Stefan Hanreich:
>> Shouldn't we try to get the MTU of the bridge when it's set to 'auto'
>> and then setup the other interfaces accordingly? Or am I
>> misunderstanding what 'auto' does?
> 
> While this is still an issue, it at least makes the MTU work if it is
> explicitly set, we can add the functionality for auto in a subsequent patch.
> 

so should this be applied as is for now?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Stefan Hanreich]

On 11/15/24 15:58, Thomas Lamprecht wrote:
> Am 15.11.24 um 14:44 schrieb Stefan Hanreich:
>>> Shouldn't we try to get the MTU of the bridge when it's set to 'auto'
>>> and then setup the other interfaces accordingly? Or am I
>>> misunderstanding what 'auto' does?
>>
>> While this is still an issue, it at least makes the MTU work if it is
>> explicitly set, we can add the functionality for auto in a subsequent patch.
>>
> 
> so should this be applied as is for now?

Yes, it only improves the current state (where neither explicit MTU nor
auto are working).


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve-network] fix #5324: non vlanaware zone: add mtu to veth links

[Thomas Lamprecht]

Am 25.03.24 um 18:01 schrieb Alexandre Derumier:
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
>  src/PVE/Network/SDN/Zones/VlanPlugin.pm            | 3 +++
>  src/test/zones/vlan/bridge/expected_sdn_interfaces | 4 ++++
>  src/test/zones/vlan/bridge/sdn_config              | 2 +-
>  3 files changed, 8 insertions(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel