[pbs-devel] [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync

[pbs-devel] [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync

[Nicolas Frey]

fixes regression from 524cf1e that made `datastore::s3_refresh` sync
but did not change the ApiHandler matching part here

This would result in a panic every time an s3-refresh was initiated

Fixes: https://forum.proxmox.com/threads/178655
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 src/bin/proxmox_backup_manager/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
index 57b4ca29..5c65c5ec 100644
--- a/src/bin/proxmox_backup_manager/datastore.rs
+++ b/src/bin/proxmox_backup_manager/datastore.rs
@@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
 
     let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
     let result = match info.handler {
-        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
+        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
         _ => unreachable!(),
     };
 
-- 
2.47.3


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync

[Samuel Rufinatscha]

Thanks, this makes sense - the ApiHandler mismatch explains the panic.

Reviewed-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>

On 1/5/26 11:34 AM, Nicolas Frey wrote:
> fixes regression from 524cf1e that made `datastore::s3_refresh` sync
> but did not change the ApiHandler matching part here
> 
> This would result in a panic every time an s3-refresh was initiated
> 
> Fixes: https://forum.proxmox.com/threads/178655
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   src/bin/proxmox_backup_manager/datastore.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
> index 57b4ca29..5c65c5ec 100644
> --- a/src/bin/proxmox_backup_manager/datastore.rs
> +++ b/src/bin/proxmox_backup_manager/datastore.rs
> @@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
>   
>       let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
>       let result = match info.handler {
> -        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
> +        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>           _ => unreachable!(),
>       };
>   



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

Re: [pbs-devel] [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync

[Christian Ebner]

Patch looks good to me and restores the correct behavior of the cli command.

On 1/5/26 11:34 AM, Nicolas Frey wrote:
> fixes regression from 524cf1e that made `datastore::s3_refresh` sync
> but did not change the ApiHandler matching part here
> 
> This would result in a panic every time an s3-refresh was initiated
> 
> Fixes: https://forum.proxmox.com/threads/178655

Might reference the blamed commit in a fixes trailer as well for easier 
lookup and search:

Fixes: 524cf1e7 ("api: admin: make s3 refresh handler sync")

> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>   src/bin/proxmox_backup_manager/datastore.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
> index 57b4ca29..5c65c5ec 100644
> --- a/src/bin/proxmox_backup_manager/datastore.rs
> +++ b/src/bin/proxmox_backup_manager/datastore.rs
> @@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
>   
>       let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
>       let result = match info.handler {
> -        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
> +        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>           _ => unreachable!(),
>       };
>   

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] superseded: [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync

[Nicolas Frey]

Superseded-by: https://lore.proxmox.com/pbs-devel/20260107124604.159625-1-n.frey@proxmox.com/T/#u

On 1/5/26 11:34 AM, Nicolas Frey wrote:
> fixes regression from 524cf1e that made `datastore::s3_refresh` sync
> but did not change the ApiHandler matching part here
> 
> This would result in a panic every time an s3-refresh was initiated
> 
> Fixes: https://forum.proxmox.com/threads/178655
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  src/bin/proxmox_backup_manager/datastore.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
> index 57b4ca29..5c65c5ec 100644
> --- a/src/bin/proxmox_backup_manager/datastore.rs
> +++ b/src/bin/proxmox_backup_manager/datastore.rs
> @@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
>  
>      let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
>      let result = match info.handler {
> -        ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
> +        ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
>          _ => unreachable!(),
>      };
>  



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel