From: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Nicolas Frey <n.frey@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/1] fix: s3: make s3_refresh apihandler sync
Date: Mon, 5 Jan 2026 16:22:16 +0100 [thread overview]
Message-ID: <2be9a5a5-41d6-43c4-b25c-5029de7ea456@proxmox.com> (raw)
In-Reply-To: <20260105103407.63587-1-n.frey@proxmox.com>
Thanks, this makes sense - the ApiHandler mismatch explains the panic.
Reviewed-by: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
On 1/5/26 11:34 AM, Nicolas Frey wrote:
> fixes regression from 524cf1e that made `datastore::s3_refresh` sync
> but did not change the ApiHandler matching part here
>
> This would result in a panic every time an s3-refresh was initiated
>
> Fixes: https://forum.proxmox.com/threads/178655
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
> src/bin/proxmox_backup_manager/datastore.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/bin/proxmox_backup_manager/datastore.rs b/src/bin/proxmox_backup_manager/datastore.rs
> index 57b4ca29..5c65c5ec 100644
> --- a/src/bin/proxmox_backup_manager/datastore.rs
> +++ b/src/bin/proxmox_backup_manager/datastore.rs
> @@ -339,7 +339,7 @@ async fn s3_refresh(mut param: Value, rpcenv: &mut dyn RpcEnvironment) -> Result
>
> let info = &api2::admin::datastore::API_METHOD_S3_REFRESH;
> let result = match info.handler {
> - ApiHandler::Async(handler) => (handler)(param, info, rpcenv).await?,
> + ApiHandler::Sync(handler) => (handler)(param, info, rpcenv)?,
> _ => unreachable!(),
> };
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2026-01-05 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 10:34 Nicolas Frey
2026-01-05 15:22 ` Samuel Rufinatscha [this message]
2026-01-07 11:37 ` Christian Ebner
2026-01-07 12:47 ` [pbs-devel] superseded: " Nicolas Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be9a5a5-41d6-43c4-b25c-5029de7ea456@proxmox.com \
--to=s.rufinatscha@proxmox.com \
--cc=n.frey@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.