Re: [pbs-devel] [PATCH proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection

[Lukas Wagner <l.wagner@proxmox.com>]

Hello,

tested this on the current master branch.
Navigated to `http://<ip>:8007`, redirect to `https://<ip>:8007` works as expected.

Code LGTM.

Consider this:

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

On 6/22/23 11:15, Max Carrara wrote:
> This patch series adds support for redirecting HTTP requests to HTTPS. This is
> done by peeking into the incoming TCP stream's buffer in order to check whether
> the client initiates a TLS handshake or not.
> 
> Secure and insecure connections are then sent along separate channels, allowing
> them to be handled by different `hyper::Server`s (if so desired).
> 
> Finally, `proxmox-backup-proxy` is adapted correspondingly, making it a little
> more convenient to access PBS via its web interface.
> 
> proxmox:
> 
> Max Carrara (2):
>    rest-server: Add `BiAcceptBuilder`
>    rest-server: Add `Redirector`
> 
>   proxmox-rest-server/src/connection.rs | 327 ++++++++++++++++++++++++++
>   proxmox-rest-server/src/lib.rs        |   2 +-
>   proxmox-rest-server/src/rest.rs       |  76 ++++++
>   3 files changed, 404 insertions(+), 1 deletion(-)
> 
> 
> proxmox-backup:
> 
> Max Carrara (1):
>    proxy: redirect HTTP requests to HTTPS
> 
>   src/bin/proxmox-backup-proxy.rs | 45 ++++++++++++++++++++++++++++-----
>   1 file changed, 38 insertions(+), 7 deletions(-)
> 

-- 
- Lukas