From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] vzdump: fix notifications for backing up VMs with 2+ disks to PBS
Date: Fri, 25 Aug 2023 15:32:11 +0200 [thread overview]
Message-ID: <2afa46e1-9020-44b1-86c8-937bd9029028@proxmox.com> (raw)
In-Reply-To: <20230825094512.271010-1-l.wagner@proxmox.com>
Am 25/08/2023 um 11:45 schrieb Lukas Wagner:
> In some situations, such as backing up VMs with 2 or more disks to
> PBS, we get passed the backup archive size as a string instead of
> as an integer. This led to errors rendering the notification template
> down the line.
>
> This commit explicitly casts the data from the task table to an int.
> It would be a good idea to actually hunt down the places that produced
> the string instead of an integer, but as a quick fix and as a
> safeguard against similar lurking errors this approach is fine, IMO.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> Popped up in:
> https://forum.proxmox.com/threads/keine-mails-mehr-nach-backup.132675/
>
> PVE/VZDump.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-08-25 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 9:45 [pve-devel] " Lukas Wagner
2023-08-25 13:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2afa46e1-9020-44b1-86c8-937bd9029028@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.