all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage] rbd: alloc image: fix #3970 avoid ambiguous rbd path
Date: Mon, 11 Apr 2022 09:39:51 +0200	[thread overview]
Message-ID: <2a67ca76-f10f-5c2f-44a7-9d9da0c36c78@proxmox.com> (raw)
In-Reply-To: <1649404843.ds1yioa8qv.astroid@nora.none>

On 08.04.22 10:04, Fabian Grünbichler wrote:
> On April 6, 2022 1:46 pm, Aaron Lauterer wrote:
>> If two RBD storages use the same pool, but connect to different
>> clusters, we cannot say to which cluster the mapped RBD image belongs to
>> if krbd is used. To avoid potential data loss, we need to verify that no
>> other storage is configured that could have a volume mapped under the
>> same path before we create the image.
>>
>> The ambiguous mapping is in
>> /dev/rbd/<pool>/<ns>/<image> where the namespace <ns> is optional.
>>
>> Once we can tell the clusters apart in the mapping, we can remove these
>> checks again.
>>
>> See bug #3969 for more information on the root cause.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> 
> Acked-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> 
> (small nit below, and given the rather heavy-handed approach a 2nd ack 
> might not hurt.. IMHO, a few easily fixable false-positives beat more 
> users actually running into this with move disk/volume and losing 
> data..)

The obvious question to me is: why bother with this workaround when we can
make udev create the symlink now already?

Patching the rules file and/or binary shipped by ceph-common, or shipping our
own such script + rule, would seem relatively simple.





  reply	other threads:[~2022-04-11  7:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 11:46 Aaron Lauterer
2022-04-08  8:04 ` Fabian Grünbichler
2022-04-11  7:39   ` Thomas Lamprecht [this message]
2022-04-11  9:08     ` Aaron Lauterer
2022-04-11 12:17       ` Thomas Lamprecht
2022-04-11 14:49         ` Aaron Lauterer
2022-04-12  8:35           ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a67ca76-f10f-5c2f-44a7-9d9da0c36c78@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal