* [PATCH qemu-sever] api: remove blank line
@ 2026-11-19 12:44 Dominik Rusovac
2026-11-19 15:21 ` Fiona Ebner
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Rusovac @ 2026-11-19 12:44 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
---
src/PVE/API2/Qemu.pm | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
index b798a590..e8c93df6 100644
--- a/src/PVE/API2/Qemu.pm
+++ b/src/PVE/API2/Qemu.pm
@@ -2395,7 +2395,6 @@ my $update_vm_api = sub {
}
if ($param->{memory} || defined($param->{balloon})) {
-
my $memory = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory};
my $maxmem = get_current_memory($memory);
my $balloon =
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH qemu-sever] api: remove blank line
2026-11-19 12:44 [PATCH qemu-sever] api: remove blank line Dominik Rusovac
@ 2026-11-19 15:21 ` Fiona Ebner
0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2026-11-19 15:21 UTC (permalink / raw)
To: Dominik Rusovac, pve-devel
Am 19.11.26 um 1:44 PM schrieb Dominik Rusovac:
> Signed-off-by: Dominik Rusovac <d.rusovac@proxmox.com>
> ---
> src/PVE/API2/Qemu.pm | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/PVE/API2/Qemu.pm b/src/PVE/API2/Qemu.pm
> index b798a590..e8c93df6 100644
> --- a/src/PVE/API2/Qemu.pm
> +++ b/src/PVE/API2/Qemu.pm
> @@ -2395,7 +2395,6 @@ my $update_vm_api = sub {
> }
>
> if ($param->{memory} || defined($param->{balloon})) {
> -
> my $memory = $param->{memory} || $conf->{pending}->{memory} || $conf->{memory};
> my $maxmem = get_current_memory($memory);
> my $balloon =
Our codebase has quite a few occurrences of such blank lines at the
start of branches. AFAICS, neither our style guide nor our perltidy
config enforce their absence. If we do want to change it, we should do
it there, and the next 'make tidy' will take care of it. Personally, I
prefer not having blanks in such places, but I'm not sure we have
consensus about that.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 12:44 [PATCH qemu-sever] api: remove blank line Dominik Rusovac
2026-11-19 15:21 ` Fiona Ebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.