all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Philipp Hufnagl <p.hufnagl@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs
Date: Wed, 20 Sep 2023 15:12:20 +0200	[thread overview]
Message-ID: <28c70ad0-ce49-49fe-a46f-87414a45f0c8@proxmox.com> (raw)
In-Reply-To: <1695211533.2t6opgxjzx.astroid@yuna.none>

On 9/20/23 14:09, Fabian Grünbichler wrote:
> On September 20, 2023 1:50 pm, Dominik Csapak wrote:
>> On 9/20/23 13:46, Fabian Grünbichler wrote:
>>> On September 20, 2023 1:07 pm, Dominik Csapak wrote:
>>>> LGTM and works as advertised.
>>> it breaks downloading container templates that are compressed with one
>>> of the "known" compression algorithms (such as gz).
>>>
>>> probably the detect-compression parameter and handling needs to go back
>>> in (that was the reason it was there in the first place!), or some other
>>> solution needs to be found..
>>>
>>>
>> ah yes ofc, sorry for the oversight
>>
>> couldn't we simply check in the backend for the download for the content type?
>> as we only really need to unpack isos?
> the "query url" part doesn't know about (storage) content types. and it
> returns the file name, so we can't let it detect compression but throw
> that part away, else we get the uncompressed filename instead of the
> compressed one (exactly what happens with v7 now).
>
> that's why we originally made the client/GUI make the choice:
>
> iso download dialogue:
> - query url with compression support
> - allow overriding (de)compression
> - pass (de)compression to download if set
>
> other download dialogues (currently only templates):
> - query url without compression support
> - don't offer (de)compression choice
> - (de)compression is never set, thus never passed to download
>
> in addition, the download backend (which knows about content types) also
> only allows decompression for isos (at least for the time being, if we
> ever revisit and allow plain container template archives then all of
> this is moot anyway ;))

Thank you for reviewing this! I will make a v8 very soon featuring 
detect_compression again!





      reply	other threads:[~2023-09-20 13:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 13:56 Philipp Hufnagl
2023-09-11 13:56 ` [pve-devel] [PATCH manager v7 1/2] fix #4849: api: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-09-11 13:56 ` [pve-devel] [PATCH manager v7 2/2] fix #4849: ui: " Philipp Hufnagl
2023-09-20 11:07 ` [pve-devel] [PATCH manager v7 0/2] fix #4849: allow download of compressed ISOs Dominik Csapak
2023-09-20 11:46   ` Fabian Grünbichler
2023-09-20 11:50     ` Dominik Csapak
2023-09-20 11:54       ` Dominik Csapak
2023-09-20 12:09       ` Fabian Grünbichler
2023-09-20 13:12         ` Philipp Hufnagl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28c70ad0-ce49-49fe-a46f-87414a45f0c8@proxmox.com \
    --to=p.hufnagl@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal