Re: [PATCH proxmox-ve-rs 8/9] ve-config: frr: implement frr config generation for route maps

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 3/27/26 12:16 PM, Hannes Laimer wrote:

[snip]

>> +    /// Add a list of Route Map Entries to a [`FrrConfig`].
>> +    ///
>> +    /// This method takes a list of Route Map Entries and adds them to given FRR configuration.
>> +    /// Existing Route Map entries with the same name, but different ordering number will remain in
>> +    /// the configuration. Entries with the same ordering will get merged.
>> +    ///
>> +    /// This behavior is different from Prefix Lists, where we overwrite existing Prefix Lists in
>> +    /// the FRR configuration. The reason for this is that users can override the Route Map setting
>> +    /// in the EVPN controller.
>> +    pub fn build_frr_route_maps(
>> +        config: impl IntoIterator<Item = RouteMap>,
>> +        frr_config: &mut FrrConfig,
>> +    ) -> Result<(), anyhow::Error> {
>> +        for route_map in config.into_iter() {
>> +            let RouteMap::RouteMapEntry(route_map) = route_map;
>> +            let route_map_name = RouteMapName::new(route_map.id.route_map_id.to_string());
>> +
>> +            if let Some(frr_route_map) = frr_config.routemaps.get_mut(&route_map_name) {
>> +                let idx =
>> +                    frr_route_map.partition_point(|element| element.seq <= route_map.id().order());
>> +                frr_route_map.insert(idx, route_map.into());
> 
> with this we would end up having multiple entries with the same seq, frr
> doesn't care, just bringing it up cause the doc mentions merging

yeah, the FRR merging logic is what's being relied upon here, i.e.:

berserker# configure
berserker(config)# route-map test permit 123
berserker(config-route-map)# match evpn vni 1111
berserker(config-route-map)# exit
berserker(config)# route-map test permit 123
berserker(config-route-map)# set metric 1111
berserker(config-route-map)# exit
berserker(config)# exit
berserker# show running-config

[...]

route-map test permit 123
 match evpn vni 1111
 set metric 1111
exit
!

[...]

------

I'll make sure to make this clearer in the documentation!