From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] build.sh: allow building multiple crates
Date: Tue, 15 Apr 2025 17:45:47 +0200 [thread overview]
Message-ID: <27fe79bf-68e4-43a3-b25a-ae1fd29b66dd@proxmox.com> (raw)
In-Reply-To: <20250415120015.886971-1-c.heiss@proxmox.com>
On 15/04/2025 14:00, Christoph Heiss wrote:
> Instead of just looking at the first argument, iterate over all of them
> and build them one by one.
>
> Useful if e.g. applying patch series or generally working with multiple
> crates in this repo, to then be able to run e.g.
>
> $ ./build.sh proxmox-log proxmox-serde
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> build.sh | 62 +++++++++++++++++++++++++++++---------------------------
> 1 file changed, 32 insertions(+), 30 deletions(-)
>
> diff --git a/build.sh b/build.sh
> index 7aa0a85b..9857905a 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -1,36 +1,38 @@
> -#!/bin/sh
> +#!/bin/bash
I would prefer keeping such basic scrips posix shell conform, I do not want
to have to install bash, or any advanced shell for that matter, if doing
minimal bootstrapping.
But I think Fabian got a legit answer here, this is already possible
through the make targets, so lets just keep this slightly more trivial
for now.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2025-04-15 15:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 12:00 Christoph Heiss
2025-04-15 12:09 ` Fabian Grünbichler
2025-04-15 12:40 ` Christoph Heiss
2025-04-15 15:45 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27fe79bf-68e4-43a3-b25a-ae1fd29b66dd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal