all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: Re: [PATCH widget-toolkit 1/1] dns: optionally send delete for optional values
Date: Fri, 1 Mar 2024 12:43:12 +0100	[thread overview]
Message-ID: <27bdeeee-a91c-47ab-ae20-c52f512e632f@proxmox.com> (raw)
In-Reply-To: <20240301090341.1342682-2-d.csapak@proxmox.com>

On 01/03/2024 10:03, Dominik Csapak wrote:
> pbs only deletes the optional values here when they are sent with the
> 'delete' parameter, in contrast to pve/pmg that don't have a delete
> parameter currently and always use the parameters as source of truth.
> 
> So to handle that, optionally set deleteEmpty if set from outside
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/node/DNSEdit.js | 6 ++++++
>  src/node/DNSView.js | 4 ++++
>  2 files changed, 10 insertions(+)
> 
>

applied, with a follow up for the comment to avoid coupling this to a
specific downstream dependency, that just will get outdated and has not
much use on its own anyway here, thanks!




  reply	other threads:[~2024-03-01 11:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  9:03 [pbs-devel] [PATCH widget-toolkit/proxmox-backup] ui: fix deleting dns servers Dominik Csapak
2024-03-01  9:03 ` [pbs-devel] [PATCH widget-toolkit 1/1] dns: optionally send delete for optional values Dominik Csapak
2024-03-01 11:43   ` Thomas Lamprecht [this message]
2024-03-01  9:03 ` [pbs-devel] [PATCH proxmox-backup 1/1] ui: fix deleting of optional dns server entries Dominik Csapak
2024-03-04 13:53   ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27bdeeee-a91c-47ab-ae20-c52f512e632f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal