[yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property

[yew-devel] [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property

[Dominik Csapak]

namely for the top level button, otherwise the disabled property has no
effect.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/widget/menu/menu_button.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/widget/menu/menu_button.rs b/src/widget/menu/menu_button.rs
index 50f85b3..2e2ed7f 100644
--- a/src/widget/menu/menu_button.rs
+++ b/src/widget/menu/menu_button.rs
@@ -248,6 +248,7 @@ impl Component for PwtMenuButton {
 
         let mut button = Button::new(&props.text)
             .show_arrow(props.show_arrow)
+            .disabled(props.disabled)
             .attribute("aria-haspopup", "true")
             .attribute("aria-expanded", self.show_submenu.then_some("true"))
             .tabindex(props.tabindex)
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] [PATCH yew-widget-toolkit 2/2] state: selection: make selection interface more consistent

[Dominik Csapak]

due to the interior mutability of th Selection (it uses Rc<RefCell<>>),
we don't need the selection to be mutable when we select something. This
is reflected in in the interface for e.g. `select()` and `toggle()`
which only take a `&self`. For `bulk_select()` the same logic can be
applied, but it still took a `&mut self` which was not a problem, but it
was unnecessary. To make it more consistent, simply change from `&mut
self` to `&self`.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/state/selection.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/state/selection.rs b/src/state/selection.rs
index 21e8e85..6866436 100644
--- a/src/state/selection.rs
+++ b/src/state/selection.rs
@@ -151,7 +151,7 @@ impl Selection {
     /// # Panics
     ///
     /// If multiselect is false.
-    pub fn bulk_select(&mut self, map: HashSet<Key>) {
+    pub fn bulk_select(&self, map: HashSet<Key>) {
         self.inner.borrow_mut().bulk_select(map);
         self.notify_listeners();
     }
-- 
2.39.5



_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel

[yew-devel] applied: [PATCH yew-widget-toolkit 1/2] widget: menu button: actually use 'disabled' property

[Dietmar Maurer]

applied both patches


_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel