all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 1/1] fix #4869: Show state in management interface ComboBox
Date: Tue, 10 Oct 2023 13:55:43 +0200	[thread overview]
Message-ID: <2730c950-b0d7-45dc-af83-80ff808da9b7@proxmox.com> (raw)
In-Reply-To: <f33tfdti2sgqzfe2tfoq5pnu7ut5rqybvyk2yaun7cmjc3qjpu@g65liga3lt4p>

Am 10/10/2023 um 13:33 schrieb Christoph Heiss:
> On Fri, Aug 04, 2023 at 12:26:46PM +0200, Filip Schauer wrote:
>> @@ -347,7 +347,7 @@ sub create_ipconf_view {
>>
>>      my $get_device_desc = sub {
>>  	my $iface = shift;
>> -	return "$iface->{name} - $iface->{mac} ($iface->{driver})";
>> +	return "$iface->{name} - $iface->{mac} ($iface->{driver}) - $iface->{state}";
>
> I think it would be better to only show the state if the interface is
> actually UP - thus drawing immediate attention to these list entries and
> not completely overloading that dropdown.
> 
> Maybe even append it as "(UP)" instead of by dash (as it does not really
> identify the interface, but rather is a property of it).
> 

Or, if the GTK component and available fonts support it we could also use
unicode

UP   -> 🟢 https://unicode-explorer.com/c/1F7E2
DOWN -> ◯ (preferred, easier to differ for vision impaired people) or ⬤
        https://unicode-explorer.com/c/25EF or https://unicode-explorer.com/c/2B24

Would use less space and probably look better, if it works that is ^^




  reply	other threads:[~2023-10-10 11:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04 10:26 [pve-devel] [PATCH installer 0/1] " Filip Schauer
2023-08-04 10:26 ` [pve-devel] [PATCH installer 1/1] " Filip Schauer
2023-10-10 11:33   ` Christoph Heiss
2023-10-10 11:55     ` Thomas Lamprecht [this message]
2023-10-10 12:56       ` Christoph Heiss
2023-10-10 13:13         ` Thomas Lamprecht
2023-10-11  9:54           ` Filip Schauer
2023-10-11 10:58             ` Thomas Lamprecht
2023-10-11 15:20               ` Filip Schauer
2023-10-12 13:04                 ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2730c950-b0d7-45dc-af83-80ff808da9b7@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal