all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [RFC edk2-firmware] d/rules: re-enable PVSCSI support
@ 2023-03-23 10:10 Fiona Ebner
  2023-03-23 10:23 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2023-03-23 10:10 UTC (permalink / raw)
  To: pve-devel

It is not maintained anymore and got disabled by default in upstream
commit 57783adfb5 ("OvmfPkg: Change default to disable MptScsi and
PvScsi"). Re-enable it to preserve backwards compatibility in Proxmox
VE.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Or should we just keep it disabled, because it's unsupported and note
it as a known issue? There might not be too much demand, but maybe
it's better to delay it until PVE 8.0?

There also is a LSI SCSI driver which actually has a maintainer, but
was never enabled by default. But as long as there is no user demand
for it, I guess it's not worth enabling.

 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index abc4b77..acd304d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -25,6 +25,7 @@ COMMON_FLAGS += -DNETWORK_IP6_ENABLE=TRUE
 COMMON_FLAGS += -DNETWORK_TLS_ENABLE
 COMMON_FLAGS += -DSECURE_BOOT_ENABLE=TRUE
 COMMON_FLAGS += -DTPM2_ENABLE=TRUE
+COMMON_FLAGS += -DPVSCSI_ENABLE=TRUE
 OVMF_COMMON_FLAGS = $(COMMON_FLAGS)
 OVMF_2M_FLAGS = $(OVMF_COMMON_FLAGS) -DFD_SIZE_2MB
 OVMF_4M_FLAGS = $(OVMF_COMMON_FLAGS) -DFD_SIZE_4MB
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [RFC edk2-firmware] d/rules: re-enable PVSCSI support
  2023-03-23 10:10 [pve-devel] [RFC edk2-firmware] d/rules: re-enable PVSCSI support Fiona Ebner
@ 2023-03-23 10:23 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-03-23 10:23 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

Am 23/03/2023 um 11:10 schrieb Fiona Ebner:
> It is not maintained anymore and got disabled by default in upstream
> commit 57783adfb5 ("OvmfPkg: Change default to disable MptScsi and
> PvScsi"). Re-enable it to preserve backwards compatibility in Proxmox
> VE.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Or should we just keep it disabled, because it's unsupported and note
> it as a known issue? There might not be too much demand, but maybe
> it's better to delay it until PVE 8.0?

Yes, if then definitively 8.0 material; as then we can also use the
pve7to8 checking script to warn/notify people (that care enough to
use it). But tbh, I'd maybe add a notice-level hint and mark it as
deprecated but still pull it along as long as it somewhat works;
not much to gain by disabling it fully.

> 
> There also is a LSI SCSI driver which actually has a maintainer, but
> was never enabled by default. But as long as there is no user demand
> for it, I guess it's not worth enabling.
> 
>  debian/rules | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-03-23 10:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 10:10 [pve-devel] [RFC edk2-firmware] d/rules: re-enable PVSCSI support Fiona Ebner
2023-03-23 10:23 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal