From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH widget-toolkit] panel/RRDCharts: enable scrolling for RRDCharts on touchscreens
Date: Mon, 23 Aug 2021 18:17:26 +0200 [thread overview]
Message-ID: <26df0a79-fa25-bebb-dc99-81456c9ba390@proxmox.com> (raw)
In-Reply-To: <20210805103135.1287114-1-d.csapak@proxmox.com>
On 05/08/2021 12:31, Dominik Csapak wrote:
> quote from extjs docs (AbstractChart.js):
>
> If you do have a chart inside a scrollable view, even if it has no
> interactions, you have to set its touchAction config to the following:
>
> touchAction: {
> panX: true,
> panY: true
> }
>
> Otherwise, if a touch action started on a chart,
> a swipe will not scroll the view.
>
> Since we have RRDCharts always in a scrollable view, and it does not seem to
> hurt non-touchscreens, enable it by default so that users on touchscreens
> can scroll it.
>
> Reported by users in the forum:
> https://forum.proxmox.com/threads/minor-but-annoying-ipad-swipe-bug.93686
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/panel/RRDChart.js | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-08-23 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 10:31 [pve-devel] " Dominik Csapak
2021-08-23 16:17 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26df0a79-fa25-bebb-dc99-81456c9ba390@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.