From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2] use non SMM ovmf code file for i440fx machines
Date: Thu, 21 Oct 2021 12:39:36 +0200 [thread overview]
Message-ID: <25da0489-dc1e-a5c3-fc6b-ea0f8e0c80c4@proxmox.com> (raw)
In-Reply-To: <20211011121024.921936-1-d.csapak@proxmox.com>
On 11.10.21 14:10, Dominik Csapak wrote:
> ovmf with SMM enabled will not boot on i440fx (hangs on graphics
> initialization), so load the non SMM variant.
>
> should be no issue regarding live-migration since it never worked with
> this anyway.
>
> adapts the test and adds one with q35
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * encode 'no-smm' instead of machine type in the ovmf hash
> * move the is_q35 checks out of the get_ovmf_files
>
> PVE/API2/Qemu.pm | 4 ++-
> PVE/QemuServer.pm | 26 +++++++++++------
> test/cfg2cmd/efi-secboot-and-tpm-q35.conf | 6 ++++
> test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd | 28 +++++++++++++++++++
> test/cfg2cmd/efi-secboot-and-tpm.conf | 2 +-
> test/cfg2cmd/efi-secboot-and-tpm.conf.cmd | 2 +-
> 6 files changed, 57 insertions(+), 11 deletions(-)
> create mode 100644 test/cfg2cmd/efi-secboot-and-tpm-q35.conf
> create mode 100644 test/cfg2cmd/efi-secboot-and-tpm-q35.conf.cmd
>
>
With Stefan's T-b and R-b applied, thanks!
prev parent reply other threads:[~2021-10-21 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 12:10 [pve-devel] " Dominik Csapak
2021-10-21 10:38 ` Stefan Reiter
2021-10-21 10:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25da0489-dc1e-a5c3-fc6b-ea0f8e0c80c4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.