From: Fiona Ebner <f.ebner@proxmox.com>
To: Jing Luo <jing@jing.rocks>, pve-devel@lists.proxmox.com
Subject: [pve-devel] applied: [PATCH v2 pve-qemu-kvm] patches: pbs block driver: correct a data type
Date: Mon, 10 Jun 2024 16:12:08 +0200 [thread overview]
Message-ID: <23ec758b-2f7a-429d-8ae7-916369656f44@proxmox.com> (raw)
In-Reply-To: <20240610122909.1216178-2-jing@jing.rocks>
Am 10.06.24 um 14:05 schrieb Jing Luo:
> gcc warns (-Werror=type-limits) that it will always be false for the
> if statement. This is because here s->aid is defined as char, while
> proxmox_restore_open_image() returns an int.
>
> This is probably because chars are treated as unsigned on arm arch but
> signed on x86 arch:
>
> https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char
>
> Signed-off-by: Jing Luo <jing@jing.rocks>
> --
applied, thanks!
Here, a '-' was missing, so the below stuff would still be interpreted
as part of the commit message. I fixed that when applying, improved the
message slightly and made a follow-up to have a dedicated error message
for when the returned value is too large.
Best Regards,
Fiona
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-06-10 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240607094734.3883693-1-jing@jing.rocks>
2024-06-07 11:49 ` [pve-devel] [PATCH pve-qemu-kvm] patch: " Fiona Ebner
2024-06-10 1:48 ` Jing Luo via pve-devel
[not found] ` <57a95560b7c8bce55d2e8270d18d9778@jing.rocks>
2024-06-10 9:27 ` Fiona Ebner
2024-06-10 12:05 ` [pve-devel] [PATCH v2 pve-qemu-kvm] patches: " Jing Luo via pve-devel
[not found] ` <20240610122909.1216178-2-jing@jing.rocks>
2024-06-10 14:12 ` Fiona Ebner [this message]
2024-06-10 8:53 ` [pve-devel] [PATCH pve-qemu-kvm] patch: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23ec758b-2f7a-429d-8ae7-916369656f44@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=jing@jing.rocks \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.