Re: [pve-devel] [PATCH manager] ui: fix height 'extra cpu flags' field in create wizard

[Dominik Csapak <d.csapak@proxmox.com>]

forgot to write: we should apply this for stable-7 as well

On 6/15/23 10:08, Dominik Csapak wrote:
> this field has a fixed height, which is too tall for the create wizard,
> and one cannot see the last entry when scrolling all the way down.
> 
> to fix this, make it 20px shorter
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively we could also increase the height in the create wizard
> 
> the optimal solution would be to improve the layouting in our
> wizard/inputpanel altogether so that it automatically gets the right
> height, but that is a non-trivial rework there. imho this should work
> fine as a stopgap fix for now
> 
> (feel free to put above comment into the commit message if it seems
> appropriate)
> 
>   www/manager6/form/VMCPUFlagSelector.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ace3c531..03a119ab 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -12,7 +12,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>       hideHeaders: true,
>   
>       scrollable: 'y',
> -    height: 200,
> +    height: 180,
>   
>       unkownFlags: [],
>