[pbs-devel] applied: [PATCH proxmox v2 1/4] rest-server: handle failure in worker task setup correctly

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox v2 1/4] rest-server: handle failure in worker task setup correctly
Date: Mon, 2 Dec 2024 16:57:19 +0100	[thread overview]
Message-ID: <233b0c69-0a31-4dd1-bf6f-b9af8c8d6c05@proxmox.com> (raw)
In-Reply-To: <20241202130412.1290616-2-f.gruenbichler@proxmox.com>

Am 02.12.24 um 14:04 schrieb Fabian Grünbichler:
> if setting up a new worker fails after it has been inserted into the
> WORKER_TASK_LIST, we need to clean it up instead of bubbling up the error right
> away, else we "leak" the worker task and it never finishes..
> 
> a worker task that never finishes will indefinitely block shutdown
> of the rest server process, including the "old" process when reloading
> the rest server.
> 
> this issue was found in the wild on a system with lock contention on the
> file-based lock covering task index updating leading to lock acquiring
> timeouts.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>  proxmox-rest-server/src/worker_task.rs | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied, thanks!

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel