Re: [pve-devel] [PATCH qemu-server 2/3] config: introduce a flag to prevent writing the configuration

[Fiona Ebner <f.ebner@proxmox.com>]

Am 24.01.25 um 11:18 schrieb Thomas Lamprecht:
> Am 24.01.25 um 11:08 schrieb Fiona Ebner:
>> +sub write_config {
>> +    my ($class, $vmid, $conf) = @_;
>> +
>> +    if ($conf->{'no-write-config'}) {
>> +	log_warn("refusing to write temporary configuration with 'no-write-config' flag");
> 
> hmm, mixing config values and metadata for control flow/debugging is
> always getting hairy fast, making the config a blessed object with
> method for QEMU stuff and a clean separation of config data and such
> flags and other non-config data info might be a better alternative,
> but demanding that now would add a ton of scope and delay the fix
> significantly, so fine to go this way as stop gap.
> 
> On a v2 or on applying adding a (one of) fixme/todo/hack comment to
> note that this is not ideal, to minimize the chance that doing this
> sort of thing spreads, could be good though.
> 

Ack, will add such a FIXME comment.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel