[pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

[pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

[Dominik Csapak]

the help tooltip says it's unavailable for vms, and choosing a mode
here does not make a difference, so disable it for vms

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/window/Backup.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index cb09c7b9..21cfe246 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -126,6 +126,8 @@ Ext.define('PVE.window.Backup', {
 			if (me.vmtype === 'lxc') {
 			    pbsChangeDetectionModeSelector.setValue('__default__');
 			    pbsChangeDetectionModeSelector.setDisabled(false);
+			} else {
+			    pbsChangeDetectionModeSelector.setDisabled(true);
 			}
 		    } else {
 			if (!compressionSelector.getEditable()) {
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

[Fiona Ebner]

Am 10.04.25 um 10:08 schrieb Dominik Csapak:
> the help tooltip says it's unavailable for vms, and choosing a mode
> here does not make a difference, so disable it for vms

Maybe we should even hide it completely? It's just
distracting/additional mental load for no reason if it can't ever be
used for a VM.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

[Dominik Csapak]

On 4/10/25 10:10, Fiona Ebner wrote:
> Am 10.04.25 um 10:08 schrieb Dominik Csapak:
>> the help tooltip says it's unavailable for vms, and choosing a mode
>> here does not make a difference, so disable it for vms
> 
> Maybe we should even hide it completely? It's just
> distracting/additional mental load for no reason if it can't ever be
> used for a VM.

yes also though about that, but ultimately decided against it, since
the help tooltip explains it anyway

if you want i can send a v2 to hide it when it's not available
(so no pbs or vm)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms

[Thomas Lamprecht]

Am 10.04.25 um 10:11 schrieb Dominik Csapak:
> On 4/10/25 10:10, Fiona Ebner wrote:
>> Am 10.04.25 um 10:08 schrieb Dominik Csapak:
>>> the help tooltip says it's unavailable for vms, and choosing a mode
>>> here does not make a difference, so disable it for vms
>>
>> Maybe we should even hide it completely? It's just
>> distracting/additional mental load for no reason if it can't ever be
>> used for a VM.
> 
> yes also though about that, but ultimately decided against it, since
> the help tooltip explains it anyway
> 
> if you want i can send a v2 to hide it when it's not available
> (so no pbs or vm)

Yes, lets please hide this.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel