From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH] api: network: add return schema for interface listing
Date: Thu, 5 Dec 2024 12:53:23 +0100 [thread overview]
Message-ID: <226f3245-b39d-460d-9d08-28ee9d15fbd9@proxmox.com> (raw)
In-Reply-To: <f32df1f1-60f0-48ea-bd6d-374e6f01f777@proxmox.com>
On 12/5/24 09:43, Thomas Lamprecht wrote:
> Some extra checking would be certainly good, but FWIW, if there's not something totally
> amiss here (@Stefan Hanreich) then I could apply this now and we improve descriptions
> later™.
From a quick glance a few properties are missing. From what I can tell
it's the following:
bridge-access
bridge-learning
bridge-arp-nd-suppress
bridge-unicast-flood
bridge-multicast-flood
Taken from [1]
The descriptions are already better than what ifupdown2 man pages are
providing, but that's not really a high bar to jump over. They're fine
for now I'd say.
[1]
https://git.proxmox.com/?p=pve-common.git;a=blob;f=src/PVE/INotify.pm;h=54b883e95f3288a9dd27abe1733b8e1a96c6bad4;hb=HEAD#l945
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-12-05 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 8:27 Dominik Csapak
2024-12-05 8:29 ` Dominik Csapak
2024-12-05 8:43 ` Thomas Lamprecht
2024-12-05 11:53 ` Stefan Hanreich [this message]
2024-12-06 8:52 ` Dominik Csapak
2024-12-06 10:00 ` Thomas Lamprecht
2024-12-05 12:49 ` Gabriel Goller
2024-12-06 11:16 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226f3245-b39d-460d-9d08-28ee9d15fbd9@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal