all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] fix prune-backups validation (again)
Date: Fri, 10 Sep 2021 14:17:24 +0200	[thread overview]
Message-ID: <2255669b-a935-6daf-90d5-34051c8b8769@proxmox.com> (raw)
In-Reply-To: <20210910093718.132663-1-f.ebner@proxmox.com>

On 10.09.21 11:37, Fabian Ebner wrote:
> Commit a000e26ce7d30ba2b938402164a9a15e66dd123e caused a test failure
> in pve-manager, because now 'keep-all=0' is not thrown out upon
> validation anymore. Fix the issue the commit addressed differently,
> by simply creating a copy of the (shallow) hash first, and using
> the logic from before the commit.
> 
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage/Plugin.pm | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-09-10 12:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  9:37 [pve-devel] " Fabian Ebner
2021-09-10 12:17 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2255669b-a935-6daf-90d5-34051c8b8769@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal