From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-api-types] api-types: add lxc pending config, move_volume and resize api
Date: Wed, 26 Nov 2025 09:48:46 +0100 [thread overview]
Message-ID: <224a6a10-431f-4b85-9538-7f7e5fa6eed0@proxmox.com> (raw)
In-Reply-To: <20251125113921.3738852-1-dietmar@proxmox.com>
Am 25.11.25 um 12:39 schrieb Dietmar Maurer:
> And rename QemuPendingConfigValue to PvePendingConfigValue.
The actual rename was either not committed or overlooked? As that type is not
generated, the generate.pl file just references it.
I now renamed it to PendingConfigValue as the "Pve" prefix does not really gains
us anything, we're already in a *pve*-api-types crate after all.
The override for the bwlimit default was on the wrong type, as for LXC we use
the term Volume over the term Disk, thus failing compilation.
I addressed all these and pushed out the changes, but did not bump yet; please
check if that works now for your usecase.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-26 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:39 Dietmar Maurer
2025-11-26 8:48 ` Thomas Lamprecht [this message]
2025-11-26 10:21 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224a6a10-431f-4b85-9538-7f7e5fa6eed0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.