From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: [pdm-devel] applied: [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color
Date: Thu, 20 Mar 2025 10:03:30 +0100 (CET) [thread overview]
Message-ID: <220998712.636.1742461410731@webmail.proxmox.com> (raw)
In-Reply-To: <2b0f5897-3728-4f11-bf8f-2dec4dd2110a@proxmox.com>
applied with minor changes
> yeah looks fine to me too
>
> alternatively we could maybe do (untested):
>
> match status {
> "RUNNING" | "OK" => {},
> status if status.starts_with("WARNINGS:") => { .. warning .. }
> _ => { .. error .. }
> }
changed this to:
match record.status.as_deref() {
Some("RUNNING" | "OK") | None => {}
Some(status) if status.starts_with("WARNINGS:") => {
args.add_class("pwt-color-warning")
}
_ => args.add_class("pwt-color-error"),
}
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-03-20 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 14:32 [pdm-devel] [PATCH yew-comp/datacenter-manager] improve rendering running tasks Dominik Csapak
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 1/2] tasks: don't mark running tasks from pve with 'error' color Dominik Csapak
2025-03-20 6:25 ` Dietmar Maurer
2025-03-20 8:10 ` Dominik Csapak
2025-03-20 9:03 ` Dietmar Maurer [this message]
2025-03-18 14:32 ` [pdm-devel] [PATCH yew-comp 2/2] tasks: add loading animation for running tasks Dominik Csapak
2025-03-20 9:08 ` Dietmar Maurer
2025-03-18 14:32 ` [pdm-devel] [PATCH datacenter-manager 1/1] ui: remote " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=220998712.636.1742461410731@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal