Re: [pve-devel] [PATCH qemu-server v7 1/4] QemuServer: add new public get_default_vga_type function

[Fiona Ebner <f.ebner@proxmox.com>]

Nit: please don't use "QemuServer" as a prefix in the commit subject.
That contains no additional information (for humans, but also machines
can already see the modified file).

Am 08.04.25 um 14:27 schrieb Aaron Lauterer:
> by moving that part out of get_vga_properties.
> 
> We resolve missing parameters if necessary to make it easier to call
> from another module where we likely only have the VM config ready.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index ccdceed..cc08f6f 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -3414,6 +3414,27 @@ my sub print_ovmf_drive_commandlines {
>      return ("if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code", $var_drive_str);
>  }
>  
> +sub get_default_vga_type {
> +    my ($conf, $arch, $machine_version, $winversion) = @_;
> +
> +    $arch //= PVE::QemuServer::Helpers::get_vm_arch($conf);
> +    $winversion //= PVE::QemuServer::Helpers::windows_version($conf->{ostype});
> +    if (!$machine_version) {
> +	my $kvm_binary = PVE::QemuServer::Helpers::get_command_for_arch($arch);
> +	my $kvmver = kvm_user_version($kvm_binary);
> +	my $machine_type = PVE::QemuServer::Machine::get_vm_machine($conf, undef, $arch);
> +	$machine_version = extract_version($machine_type, $kvmver);

Nit: could have used the PVE::QemuServer::Machine::extract_version() helper.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel