From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4975: client: ignore E2BIG on `listxattr`
Date: Mon, 12 Feb 2024 11:15:22 +0100 (CET) [thread overview]
Message-ID: <2135298414.1094.1707732922887@webmail.proxmox.com> (raw)
In-Reply-To: <20240209140554.123703-1-g.goller@proxmox.com>
This is a bit too dangerous for me. As discussed offline, I would make
this a feature flag (opt-in).
> + Err(Errno::E2BIG) => {
> + log::warn!(
> + "WARNING: {} - failed to read xattrs, too big (E2BIG)",
> + read_link(proc_path).map_or("".to_string(), |p| p.display().to_string())
> + );
> + return Ok(());
> + }
next prev parent reply other threads:[~2024-02-12 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-09 14:05 Gabriel Goller
2024-02-12 10:15 ` Dietmar Maurer [this message]
2024-02-13 14:14 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2135298414.1094.1707732922887@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.