all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Laurențiu Leahu-Vlăducu" <l.leahu-vladucu@proxmox.com>
Subject: Re: [pve-devel] Strategy for Active Directory and OpenID Connect groups and usernames with spaces and other special characters
Date: Thu, 6 Mar 2025 08:51:32 +0100 (CET)	[thread overview]
Message-ID: <2108731437.5298.1741247492846@webmail.proxmox.com> (raw)
In-Reply-To: <b8fba9f6-6c83-4846-923f-2f7b93856bcf@proxmox.com>

> 1. Do we want to allow spaces in groups and/or usernames, or should we 
> prefer replacement characters (e.g. mapping space(s) to _ or some other 
> character)?

My feeling is that we need to allow all characters -  else this will be an endless issue ...

> 2. In case we want to allow spaces in groups and/or usernames, we also 
> have to ask ourselves whether we want to allow other special characters 
> as well.

see above

> 3. If we also want to allow using special characters, we have to think 
> about the encoding we use for user.cfg. Currently, we're not doing any 
> conversions, meaning that Perl could write the strings to user.cfg as 
> they are (e.g. as UTF-8), but would read them without any conversions, 
> treating the text as Latin-1.
> 
> I have already started a discussion on UTF-8 in our config files, so for 
> more details on how Perl handles encodings, look here: 
> https://lore.proxmox.com/pve-devel/082d3fe0-9c6c-494d-9ec3-f64645cd7a53@proxmox.com/T/#t

I would use url encoding for that.

> 4. We also have to think about how we want to handle upgrades after such 
> a change, especially regarding clusters. I'm specifically talking about 
> the short period of time when upgrading a cluster to a new version, 
> where not all nodes are on the same version at the same time (e.g. for a 
> few minutes). A possibility would be to already implement the changes as 
> part of PVE 8.4, meaning that the code could handle it but we would 
> disable it by default, while making it available beginning with PVE 9.0.

yes, something like that.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-06  7:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 16:10 Laurențiu Leahu-Vlăducu
2025-03-06  7:51 ` Dietmar Maurer [this message]
2025-03-06  9:09 ` Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2108731437.5298.1741247492846@webmail.proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=l.leahu-vladucu@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal