Re: [pbs-devel] [PATCH v3 proxmox-backup 0/8] *** SUBJECT HERE ***

[Lukas Wagner <l.wagner@proxmox.com>]

On  2024-02-08 14:59, Stefan Lendl wrote:
> *** BLURB HERE ***
> 
> Stefan Lendl (8):
>   api: garbage collect job status
>   gc: global prune and gc job view
>   gc: move datastore/PruneAndGC to config/PruneAndGC
>   gc: hide datastore column in local gc view
>   ui: order Prune&GC before SyncJobs
>   cli: list gc jobs with proxmox-backup-manager
>   gc: show removed and pending chunks of last run in ui
>   gc: configure width and flex on GC Jobs columns
> 
>  pbs-api-types/src/datastore.rs    |  40 +++++
>  src/api2/admin/datastore.rs       | 129 +++++++++++++++-
>  src/api2/admin/gc.rs              |  57 +++++++
>  src/api2/admin/mod.rs             |   2 +
>  src/bin/proxmox-backup-manager.rs |  33 ++++
>  www/Makefile                      |   4 +-
>  www/Utils.js                      |   6 +-
>  www/config/GCView.js              | 243 ++++++++++++++++++++++++++++++
>  www/config/PruneAndGC.js          |  52 +++++++
>  www/datastore/DataStoreList.js    |  11 +-
>  www/datastore/Panel.js            |   3 +-
>  www/datastore/PruneAndGC.js       | 133 ----------------
>  www/window/GCJobEdit.js           |  28 ++++
>  13 files changed, 593 insertions(+), 148 deletions(-)
>  create mode 100644 src/api2/admin/gc.rs
>  create mode 100644 www/config/GCView.js
>  create mode 100644 www/config/PruneAndGC.js
>  delete mode 100644 www/datastore/PruneAndGC.js
>  create mode 100644 www/window/GCJobEdit.js
> 

Apart from the requested change from chunks to bytes, these 
changes look good to me :)
Please make sure to include the cover letter in v4 ;)

With the suggested UI/API changes, consider this:

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


-- 
- Lukas