From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute
Date: Mon, 2 May 2022 08:51:21 +0200 [thread overview]
Message-ID: <20c61ee9-eadf-8995-a6fb-388f2396567c@proxmox.com> (raw)
In-Reply-To: <8f52f28f-e96c-d8df-e355-92564ec66f29@proxmox.com>
>>> + return PVE::Storage::DirPlugin::update_volume_notes( @_);
>>> +}
>>
>> makes no sense to add these? they are deprecated and unused anyway
>
> no actually, the DirPlugin implementation calls
> $class->get_volume_notes for now, so it would try to call the
> BtrfsPlugin version of those which inherits from Plugin which dies in those...
> (CephFs/CIFS/NFS actually do the same as i did here)
>
> i guess we could do (untested)
> --8<--
> shift @_; # discard class
> PVE::Storage::DirPlugin->update_volume_notes(@_);
> -->8--
i meant update_volume_attributes ofc
next prev parent reply other threads:[~2022-05-02 6:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:00 Dominik Csapak
2022-05-02 6:36 ` Thomas Lamprecht
2022-05-02 6:48 ` Dominik Csapak
2022-05-02 6:51 ` Dominik Csapak [this message]
2022-05-02 7:04 ` Thomas Lamprecht
2022-05-02 7:20 ` Dominik Csapak
2022-05-25 10:48 Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20c61ee9-eadf-8995-a6fb-388f2396567c@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal