From: Fiona Ebner <f.ebner@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH docs] vzdump: fleecing: rephrase manual vzdump example
Date: Thu, 11 Jul 2024 13:23:12 +0200 [thread overview]
Message-ID: <20a9b421-7ba2-4bc2-88ca-b569c70fbb3f@proxmox.com> (raw)
In-Reply-To: <20240711111102.1184202-1-a.lauterer@proxmox.com>
Am 11.07.24 um 13:11 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> @fiona please let me know if this works and doesn't introduce wrong
> infos.
> I think this way the sentence represents better what is happening, as
> it is not enabling it, but running that particular backup with fleecing.
>
> I am also thinking of placing the actual command of this and the now
> applied change detection mode into a code block instead of having them
> inline.
>
Fine by me :)
> vzdump.adoc | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/vzdump.adoc b/vzdump.adoc
> index 415742e..10dff9e 100644
> --- a/vzdump.adoc
> +++ b/vzdump.adoc
> @@ -149,11 +149,11 @@ With backup fleecing, such old data is cached in a fleecing image rather than
> sent directly to the backup target. This can help guest IO performance and even
> prevent hangs in certain scenarios, at the cost of requiring more storage space.
>
> -Use e.g. `vzdump 123 --fleecing enabled=1,storage=local-lvm` to enable backup
> -fleecing, with fleecing images created on the storage `local-lvm`. As always,
> -you can set the option for specific backup jobs, or as a node-wide fallback via
> -the xref:vzdump_configuration[configuration options]. In the UI, fleecing can be
> -configured in the 'Advanced' tab when editing a backup job.
> +To manually run a backup of guest `123` with fleecing images created on the
Fleecing is only supported for VMs, so I don't like the use of 'guest'
here, let's use 'VM' instead.
> +storage `local-lvm`, run `vzdump 123 --fleecing enabled=1,storage=local-lvm`. As
The duplicate 'run' in the sentence can be fine, but maybe having the
first 'run' be 'start' instead reads slightly nicer?
> +always, you can set the option for specific backup jobs, or as a node-wide
> +fallback via the xref:vzdump_configuration[configuration options]. In the UI,
> + fleecing can be configured in the 'Advanced' tab when editing a backup job.
>
> The fleecing storage should be a fast local storage, with thin provisioning and
> discard support. Examples are LVM-thin, RBD, ZFS with `sparse 1` in the storage
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-07-11 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:11 Aaron Lauterer
2024-07-11 11:23 ` Fiona Ebner [this message]
2024-07-11 11:30 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20a9b421-7ba2-4bc2-88ca-b569c70fbb3f@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.