From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] close #5571: client: fix regression for `map` command
Date: Tue, 2 Jul 2024 10:13:14 +0200 (CEST) [thread overview]
Message-ID: <2096844738.2192.1719907994082@webmail.proxmox.com> (raw)
In-Reply-To: <20240702075017.xdxukvi3mxcd2y6e@luna.proxmox.com>
> On 02.07.2024 09:50 CEST Gabriel Goller <g.goller@proxmox.com> wrote:
>
> Works great!
>
> Consider:
> Tested-by: Gabriel Goller <g.goller@proxmox.com>
> Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Thanks for double checking Gabriel!
To add, I think it would make sense to create a dedicated wrapper type for archive names, so that such issues are catched by the Rust type system at compile time. Will have a closer look at that.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-02 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 7:24 Christian Ebner
2024-07-02 7:50 ` Gabriel Goller
2024-07-02 8:13 ` Christian Ebner [this message]
2024-07-02 8:44 ` [pbs-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2096844738.2192.1719907994082@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.