From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] ui: resourcetree: move guest position on template creation
Date: Thu, 21 Oct 2021 11:49:18 +0200 [thread overview]
Message-ID: <203c51c3-aeec-1d37-4a1f-d070306cbc93@proxmox.com> (raw)
In-Reply-To: <20211004075000.922030-1-d.csapak@proxmox.com>
On 04.10.21 09:50, Dominik Csapak wrote:
> we sort templates at the end normally, but if we convert a guest to a
> template, it was not moved in the tree
>
> add it to the list of attributes that are checked for a move
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * create an array where we append the additional attributes to check
> instead of having the checks separate, this way, we can easily
> add new attributes to the list if we want to
>
> www/manager6/tree/ResourceTree.js | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>
with Aaron's T-b applied, thanks to both!
prev parent reply other threads:[~2021-10-21 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 7:50 [pve-devel] " Dominik Csapak
2021-10-21 9:41 ` Aaron Lauterer
2021-10-21 9:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=203c51c3-aeec-1d37-4a1f-d070306cbc93@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.