all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics
@ 2026-11-20 15:22 Gabriel Goller
  2026-11-20 15:22 ` [PATCH proxmox-perl-rs 1/3] pve-rs: fabrics: list nodes of all fabrics Gabriel Goller
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Gabriel Goller @ 2026-11-20 15:22 UTC (permalink / raw)
  To: pve-devel

GET /cluster/sdn/fabrics/node returned only one node per host. The nodes
returned by list_nodes() in pve-rs were keyed by the node name, so if a
host was part of multiple fabrics, the fabric that sorts last overwrote
the others. Among others, this hid the WireGuard interfaces in the node
edit window of OSPF and BGP fabrics. The proxmox-perl-rs patch keys the
nodes by section ID (<fabric>_<node>) instead.

The API endpoints used these keys as node names for the permission check
on /nodes/<node>. GET /cluster/sdn/fabrics/all always got section IDs from
list_all(), so users with permissions only on single nodes never saw any
fabric node there. The first pve-network patch fixes this. The second
one does the same for GET /cluster/sdn/fabrics/node, which is needed with
the proxmox-perl-rs patch. It works with the old pve-rs too, so it should
be applied no later than the proxmox-perl-rs patch.


proxmox-perl-rs:

Gabriel Goller (1):
  pve-rs: fabrics: list nodes of all fabrics

 pve-rs/src/bindings/sdn/fabrics.rs | 41 ++++++++++++++++++++++++++++--
 1 file changed, 39 insertions(+), 2 deletions(-)


pve-network:

Gabriel Goller (2):
  api: fabrics: check node permissions with the node name in list_all
  api: fabrics: check node permissions with the node name in list_nodes

 src/PVE/API2/Network/SDN/Fabrics.pm      | 5 +++--
 src/PVE/API2/Network/SDN/Fabrics/Node.pm | 7 ++++---
 2 files changed, 7 insertions(+), 5 deletions(-)


Summary over all repositories:
  3 files changed, 46 insertions(+), 7 deletions(-)

-- 
Generated by murpp 0.11.0




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-20 15:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 15:22 [PATCH network/proxmox-perl-rs 0/3] Fix listing fabric nodes of hosts in multiple fabrics Gabriel Goller
2026-11-20 15:22 ` [PATCH proxmox-perl-rs 1/3] pve-rs: fabrics: list nodes of all fabrics Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 2/3] api: fabrics: check node permissions with the node name in list_all Gabriel Goller
2026-11-20 15:22 ` [PATCH pve-network 3/3] api: fabrics: check node permissions with the node name in list_nodes Gabriel Goller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal