From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH cluster v2 04/36] pmxcfs: quorum: pass the corosync membership to an optional listener
Date: Tue, 17 Nov 2026 23:34:14 +0100 [thread overview]
Message-ID: <20261117223945.862914-5-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261117223945.862914-1-t.lamprecht@proxmox.com>
Quorum alone does not tell a service whether every node contributing to
it has participated in the service's synchronization. Pass the node IDs
from each corosync quorum notification to an optional listener, and an
empty list when the connection to corosync is lost.
The listener runs on the loop thread, like the dfsm callbacks, so it
can compare corosync membership with dfsm group membership without
locking. Existing behavior is unchanged when no listener is registered.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
no changes since v1
src/pmxcfs/pmxcfs.c | 2 +-
src/pmxcfs/quorum.c | 26 +++++++++++++++++++++-----
src/pmxcfs/quorum.h | 8 +++++++-
3 files changed, 29 insertions(+), 7 deletions(-)
diff --git a/src/pmxcfs/pmxcfs.c b/src/pmxcfs/pmxcfs.c
index 2bf9145..284bae1 100644
--- a/src/pmxcfs/pmxcfs.c
+++ b/src/pmxcfs/pmxcfs.c
@@ -1019,7 +1019,7 @@ int main(int argc, char *argv[]) {
if (dcdb) {
- service_quorum = service_quorum_new();
+ service_quorum = service_quorum_new(NULL, NULL);
cfs_loop_add_service(corosync_loop, service_quorum, QB_LOOP_HIGH);
diff --git a/src/pmxcfs/quorum.c b/src/pmxcfs/quorum.c
index 0ac3cfe..3b9e012 100644
--- a/src/pmxcfs/quorum.c
+++ b/src/pmxcfs/quorum.c
@@ -35,12 +35,25 @@
#include "cfs-utils.h"
#include "loop.h"
+#include "quorum.h"
#include "status.h"
typedef struct {
quorum_handle_t handle;
+ cfs_quorum_view_fn_t view_fn;
+ gpointer view_data;
} qs_private_t;
+static void quorum_set(
+ qs_private_t *private, uint32_t quorate, gboolean quiet, const uint32_t *nodeids, size_t count
+) {
+ cfs_set_quorate(quorate, quiet);
+
+ if (private->view_fn) {
+ private->view_fn(private->view_data, quorate, nodeids, count);
+ }
+}
+
static void quorum_notification_fn(
quorum_handle_t handle,
uint32_t quorate,
@@ -64,7 +77,7 @@ static void quorum_notification_fn(
return;
}
- cfs_set_quorate(quorate, FALSE);
+ quorum_set(private, quorate, FALSE, view_list, view_list_entries);
}
static quorum_callbacks_t quorum_callbacks = {
@@ -80,7 +93,7 @@ static gboolean service_quorum_finalize(cfs_service_t *service, gpointer context
cs_error_t result;
- cfs_set_quorate(0, TRUE);
+ quorum_set(private, 0, TRUE, NULL, 0);
result = quorum_finalize(handle);
private->handle = 0;
@@ -150,7 +163,7 @@ static int service_quorum_initialize(cfs_service_t *service, gpointer context) {
return quorum_fd;
err_finalize:
- cfs_set_quorate(0, FALSE);
+ quorum_set(private, 0, FALSE, NULL, 0);
quorum_finalize(handle);
err_reset_handle:
private
@@ -185,7 +198,7 @@ loop:
cfs_critical("quorum_dispatch failed: %s", cs_strerror(result));
- cfs_set_quorate(0, FALSE);
+ quorum_set(private, 0, FALSE, NULL, 0);
quorum_finalize(handle);
private->handle = 0;
return FALSE;
@@ -197,7 +210,7 @@ static cfs_service_callbacks_t cfs_quorum_callbacks = {
.cfs_service_dispatch_fn = service_quorum_dispatch,
};
-cfs_service_t *service_quorum_new(void) {
+cfs_service_t *service_quorum_new(cfs_quorum_view_fn_t view_fn, gpointer view_data) {
cfs_service_t *service;
qs_private_t *private = g_new0(qs_private_t, 1);
@@ -205,6 +218,9 @@ cfs_service_t *service_quorum_new(void) {
return NULL;
}
+ private->view_fn = view_fn;
+ private->view_data = view_data;
+
service = cfs_service_new(&cfs_quorum_callbacks, G_LOG_DOMAIN, private);
return service;
diff --git a/src/pmxcfs/quorum.h b/src/pmxcfs/quorum.h
index 3dec79c..120a1a3 100644
--- a/src/pmxcfs/quorum.h
+++ b/src/pmxcfs/quorum.h
@@ -25,7 +25,13 @@
#include "loop.h"
-cfs_service_t *service_quorum_new(void);
+/* Called on the loop thread with the node IDs of the current corosync membership each time corosync
+ * reports a change, and with none when the connection to corosync is lost. */
+typedef void (*cfs_quorum_view_fn_t)(
+ gpointer data, uint32_t quorate, const uint32_t *nodeids, size_t count
+);
+
+cfs_service_t *service_quorum_new(cfs_quorum_view_fn_t view_fn, gpointer view_data);
void service_quorum_destroy(cfs_service_t *service);
--
2.47.3
next prev parent reply other threads:[~2026-11-17 22:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 22:34 [PATCH cluster/guest-common/qemu-server/container/manager/docs v2 00/36] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 01/36] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 02/36] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 03/36] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-17 22:34 ` Thomas Lamprecht [this message]
2026-11-17 22:34 ` [PATCH cluster v2 05/36] pmxcfs: dcdb: generate the cluster ID once the cluster is " Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 06/36] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH cluster v2 07/36] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 08/36] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 09/36] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 10/36] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-17 22:34 ` [PATCH guest-common v2 11/36] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 12/36] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 13/36] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 14/36] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 15/36] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 16/36] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 17/36] api: status: return the guest uid Thomas Lamprecht
2026-11-17 22:34 ` [PATCH qemu-server v2 18/36] tests: remote migration: check a failed command and an early tunnel end Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 19/36] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 20/36] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 21/36] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 22/36] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 23/36] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 24/36] test: remote migration: check the cleanup of the target after failures Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 25/36] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-17 22:34 ` [PATCH container v2 26/36] api: status: return the guest uid Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 27/36] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 28/36] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 29/36] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 30/36] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 31/36] ui: guest summary: show " Thomas Lamprecht
2026-11-17 22:34 ` [PATCH manager v2 32/36] api: migrate all: refuse targets that would drop " Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 33/36] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 34/36] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 35/36] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-17 22:34 ` [PATCH docs v2 36/36] pct: " Thomas Lamprecht
2026-11-18 5:57 ` superseded: [PATCH cluster/guest-common/qemu-server/container/manager/docs v2 00/36] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117223945.862914-5-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.