From: "Max R. Carrara" <m.carrara@proxmox.com>
To: pve-devel@lists.proxmox.com
Cc: Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [PATCH pve-storage v3 26/51] tree-wide: partially replace usages of regexes for 'import' vtype
Date: Tue, 17 Nov 2026 21:38:58 +0100 [thread overview]
Message-ID: <20261117203953.913035-27-m.carrara@proxmox.com> (raw)
In-Reply-To: <20261117203953.913035-1-m.carrara@proxmox.com>
Add partial support for the 'import' volume type in
`PVE::Storage::Common::Parse`. What remains unsupported right now is
parsing volume names for that type, as those require a little more
care.
Replace most usages of the `PVE::Storage::IMPORT_EXT_RE_1` regex with
parsing functions from `::Common::Parse`.
Replace the one remaining spot where we use the
`PVE::Storage::UPLOAD_IMPORT_EXT_RE_1` regex with a parsing function
as well. Add a FIXME comment for its removal on the next APIAGE reset.
Its removal will be noted in the next APIVER + APIAGE bump.
It is important to note that the `UPLOAD_IMPORT_EXT_RE_1` regex only
exists to handle the special case of excluding .ovf files from the
upload / download_url API methods. Therefore, instead of adding a
separate parser (or a flag etc.) to handle this case, just parse the
path of the up-/downloaded file regardless. Then, raise a parameter
exception when the `ovf` file extension is encountered.
Also, since the `PVE::Storage::SAFE_CHAR_CLASS_RE` regex is now
unused, migrate it to `::Common::Parse` and allow it to be obtained by
using a new helper subroutine. Add a corresponding FIXME comment here
too. This will also be added to the ApiChangeLog later.
The main reason for moving `SAFE_CHAR_CLASS_RE` and making it private
is to discourage "shotgun parsing" throughout the repo and keeping
most of our parsing code in `::Common::Parse` -- just like the other
regexes that are removed.
Additionally, we avoid duplicating the regex that way. An alternative
would have been to import it from `PVE::Storage` and use it in
`::Common::Parse`, but that would have led to cyclic imports. That
approach would not have solved the shotgun parsing problem, though.
However, since that particular regex is still important for
third-party plugin authors (for backup provider plugins in particular)
and perhaps for some isolated parsing subs that don't *really* fit
into `::Common::Parse` in the future, allowing it to be obtained
through a subroutine makes its usage much more explicit. As a side
effect, putting the regex behind a subroutine prevents it from being
altered.
Finally, add a bunch of test cases that target the `import` volume
type for the `list_volumes()` plugin API method. For all of these
tests, sort the expected and resulting list items by their volume ID
in order to make the output comparison deterministic. Iterate over the
declared content / volume types of the mocked storage config instead
of using a fixed list of vtypes as well.
Signed-off-by: Max R. Carrara <m.carrara@proxmox.com>
---
src/PVE/API2/Storage/Status.pm | 13 +-
src/PVE/BackupProvider/Plugin/Base.pm | 6 +-
src/PVE/Storage.pm | 15 ++-
src/PVE/Storage/Common/Parse.pm | 53 ++++++++
src/PVE/Storage/Plugin.pm | 9 +-
src/test/list_volumes_test.pm | 180 +++++++++++++++++++++++++-
6 files changed, 256 insertions(+), 20 deletions(-)
diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm
index 80f9f3c4..15ba1fe3 100644
--- a/src/PVE/API2/Storage/Status.pm
+++ b/src/PVE/API2/Storage/Status.pm
@@ -94,17 +94,22 @@ my sub parse_transferred_file_path_extension : prototype($$) {
my $ext = $parts->{ext};
return $ext;
}
if ($vtype eq 'import') {
- if (
- $path !~ m!${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::UPLOAD_IMPORT_EXT_RE_1$!
- ) {
+ my $parts = parse_rel_path_as_volname_parts($path, $vtype);
+
+ if (!defined($parts)) {
raise_param_exc({ filename => "invalid filename or wrong extension" });
}
- my $ext = $1;
+ my $ext = $parts->{ext};
+
+ if ($ext eq 'ovf') {
+ raise_param_exc({ filename => "wrong file extension" });
+ }
+
return $ext;
}
die "upload / download: failed to parse '$path' - unhandled content type '$vtype'\n";
}
diff --git a/src/PVE/BackupProvider/Plugin/Base.pm b/src/PVE/BackupProvider/Plugin/Base.pm
index 81b764a6..c8ef16aa 100644
--- a/src/PVE/BackupProvider/Plugin/Base.pm
+++ b/src/PVE/BackupProvider/Plugin/Base.pm
@@ -245,13 +245,13 @@ Called before the backup of the given guest is made. The archive name is
determined for the backup task and returned to the caller via a hash reference:
my $res = $backup_provider->backup_init($vmid, $vmtype, $start_time);
my $archive_name = $res->{'archive-name'};
-The archive name must contain only characters from the
-C<$PVE::Storage::SAFE_CHAR_CLASS_RE> character class as well as forward slash
-C</> and colon C<:>.
+The archive name must contain only characters from the character class returned
+by C<L<< get_re_safe_char_class()|PVE::Storage::Common::Parse/"get_re_safe_char_class" >>>
+as well as forward slash C</> and colon C<:>.
Use C<$self> to remember it for the C<backup_container()> or C<backup_vm()>
method that will be called later.
Parameters:
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 5d8413a9..d17482e6 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -21,10 +21,17 @@ use PVE::DataCenterConfig;
use PVE::Exception qw(raise_param_exc raise);
use PVE::JSONSchema;
use PVE::INotify;
use PVE::RPCEnvironment;
use PVE::SSHInfo;
+use PVE::Storage::Common qw(
+ plugin_get_vtype_subdir
+);
+use PVE::Storage::Common::Parse qw(
+ get_re_safe_char_class
+ parse_abs_path_as_volid
+);
use PVE::RESTEnvironment qw(log_warn);
use PVE::Storage::Common qw(
plugin_get_default_vtype_subdirs
);
@@ -130,13 +137,15 @@ our $VZTMPL_EXT_RE_1 = qr/\.(?|(tar)(?!\.)|tar\.(gz|xz|zst|bz2))/i;
# FIXME: remove this regex on the next APIAGE reset.
our $BACKUP_EXT_RE_2 = qr/\.(tgz|(?:tar|vma)(?:\.(${\PVE::Storage::Plugin::COMPRESSOR_RE}))?)/;
our $IMPORT_EXT_RE_1 = qr/\.(ova|ovf|qcow2|raw|vmdk)/;
+# FIXME: remove this regex on the next APIAGE reset.
our $UPLOAD_IMPORT_EXT_RE_1 = qr/\.(ova|qcow2|raw|vmdk)/;
-our $SAFE_CHAR_CLASS_RE = qr/[a-zA-Z0-9\-\.\+\=\_]/;
+# FIXME: remove this regex on the next APIAGE reset.
+our $SAFE_CHAR_CLASS_RE = get_re_safe_char_class();
our $SAFE_CHAR_WITH_WHITESPACE_CLASS_RE = qr/[ a-zA-Z0-9\-\.\+\=\_]/;
our $OVA_CONTENT_RE_1 = qr/${SAFE_CHAR_WITH_WHITESPACE_CLASS_RE}+\.(qcow2|raw|vmdk)/;
# FIXME remove with PVE 9.0, add versioned breaks for pve-manager
@@ -827,13 +836,11 @@ sub path_to_volume_id {
if ($vtype eq 'snippets') {
return ($vtype, parse_abs_path_as_volid($sid, $scfg, $path, $vtype));
}
if ($vtype eq 'import') {
- return if $filename !~ m!^/(${SAFE_CHAR_CLASS_RE}+${IMPORT_EXT_RE_1})$!;
- my $name = $1;
- return ($vtype, "$sid:import/$name");
+ return ($vtype, parse_abs_path_as_volid($sid, $scfg, $path, $vtype));
}
return;
};
diff --git a/src/PVE/Storage/Common/Parse.pm b/src/PVE/Storage/Common/Parse.pm
index ece0dac9..d397bd69 100644
--- a/src/PVE/Storage/Common/Parse.pm
+++ b/src/PVE/Storage/Common/Parse.pm
@@ -7,10 +7,12 @@ use PVE::Storage::Common qw(
);
use Exporter qw(import);
our @EXPORT_OK = qw(
+ get_re_safe_char_class
+
parse_rel_path_as_volname_parts
parse_rel_path_as_volname
parse_volname_as_parts
parse_abs_path_as_volid_parts
@@ -35,18 +37,24 @@ primarily related to.
my @VZTMPL_COMPRESSION_EXTENSIONS = ('gz', 'xz', 'zst', 'bz2');
my @BACKUP_COMPRESSION_EXTENSIONS = ('gz', 'lzo', 'zst', 'bz2');
+my @IMPORT_EXTENSIONS = ('ova', 'ovf', 'qcow2', 'raw', 'vmdk');
+
my sub join_to_re_alternations(@list) {
return join('|', map { quotemeta } @list);
}
my $RE_VZTMPL_COMPRESSION_EXTENSIONS = join_to_re_alternations(@VZTMPL_COMPRESSION_EXTENSIONS);
my $RE_BACKUP_COMPRESSION_EXTENSIONS = join_to_re_alternations(@BACKUP_COMPRESSION_EXTENSIONS);
+my $RE_IMPORT_EXTENSIONS = join_to_re_alternations(@IMPORT_EXTENSIONS);
+
+my $RE_SAFE_CHAR_CLASS = qr/[a-zA-Z0-9\-\.\+\=\_]/;
+
my $RE_PARENT_DIR = quotemeta('..');
my $RE_CONTAINS_PARENT_DIR = qr!
( ^$RE_PARENT_DIR$ ) # .. --> Entire path
|
( ^$RE_PARENT_DIR/ ) # ../ --> Beginning of path
@@ -123,15 +131,22 @@ my $RE_SNIPPETS_FILE_PATH = qr!
(?<path>
(?<file> [^/]+ )
)
!xn;
+my $RE_IMPORT_FILE_PATH = qr!
+ (?<path>
+ (?<file> ($RE_SAFE_CHAR_CLASS)+ \. (?<ext> $RE_IMPORT_EXTENSIONS) )
+ )
+!xn;
+
my $RE_FILE_PATH_FOR_VTYPE = {
iso => qr/^$RE_ISO_FILE_PATH$/,
vztmpl => qr/^$RE_VZTMPL_FILE_PATH$/,
backup => qr/^$RE_BACKUP_FILE_PATH$/,
snippets => qr/^$RE_SNIPPETS_FILE_PATH$/,
+ import => qr/^$RE_IMPORT_FILE_PATH$/,
};
my $RE_VOLNAME_FOR_VTYPE = {
iso => qr/^$RE_ISO_FILE_PATH$/,
vztmpl => qr/^$RE_VZTMPL_FILE_PATH$/,
@@ -187,10 +202,48 @@ my sub split_leading_dir_from_path($path, $directory) {
}
return;
}
+=head1 STANDALONE REGULAR EXPRESSIONS
+
+Some of the regular expressions that this module defines can be obtained using
+the subroutines listed below.
+
+B<These subroutines are primarily intended to be used by third-party plugins.>
+
+Parsing code of inbuilt plugins and other modules in the C<L<PVE::Storage>>
+namespace should instead use the constants defined in
+C<L<PVE::Storage::Common::Parse>> directly, and keep the parsing code in there
+as well.
+
+=cut
+
+=head3 get_re_safe_char_class
+
+Returns a regex consisting of a single character class that matches any
+character that is safe to use in more critical places, such as untrusted file
+names.
+
+You would typically use this to obtain a constant that you can use in your own
+parsing code:
+
+
+ my $RE_SAFE_CHAR_CLASS = get_re_safe_char_class();
+
+ # [...]
+
+ my sub is_valid_file_name($file_name) {
+ return $file_name =~ m/${RE_SAFE_CHAR_CLASS}+ \. (json|toml)/xn;
+ }
+
+=cut
+
+sub get_re_safe_char_class() {
+ return $RE_SAFE_CHAR_CLASS;
+}
+
=head1 PARSERS RELATED TO VOLUMES
The parsing functions in this section primarily deal with parsing data related
to storage volumes, primarily C<L<volname>>s and C<L<volid>>s.
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 8b4f9dde..8d79d0ed 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -1971,17 +1971,16 @@ my sub get_subdir_files {
format => 'snippet',
};
}
if ($vtype eq 'import') {
- return
- if $filename !~
- m!/(${PVE::Storage::SAFE_CHAR_CLASS_RE}+$PVE::Storage::IMPORT_EXT_RE_1)$!i;
+ my $parts = parse_abs_path_as_volid_parts($storeid, $scfg, $path, $vtype);
+ return if !defined($parts);
return {
- volid => "$storeid:import/$1",
- format => "$2",
+ volid => $parts->{volid},
+ format => $parts->{ext},
};
}
return;
};
diff --git a/src/test/list_volumes_test.pm b/src/test/list_volumes_test.pm
index 5c038a7d..a1f3eb18 100644
--- a/src/test/list_volumes_test.pm
+++ b/src/test/list_volumes_test.pm
@@ -70,10 +70,11 @@ my $scfg = {
'rootdir' => 1,
'vztmpl' => 1,
'images' => 1,
'snippets' => 1,
'backup' => 1,
+ 'import' => 1,
},
};
# The test cases are comprised of an arry of hashes with the following keys:
# description => displayed on error by Test::More
@@ -542,10 +543,175 @@ my @tests = (
'size' => DEFAULT_SIZE,
'volid' => 'local:iso/debian-9.12.0-amd64-netinst.iso',
},
],
},
+ {
+ description => 'VMID: none, valid file names for import',
+ vmid => undef,
+ files => [
+ "$storage_dir/import/import.ova",
+ "$storage_dir/import/import.ovf",
+ "$storage_dir/import/some-disk.qcow2",
+ "$storage_dir/import/some-disk.vmdk",
+ "$storage_dir/import/some-raw-disk.raw",
+ ],
+ expected => [
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/import.ova",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ovf',
+ size => DEFAULT_SIZE,
+ volid => "local:import/import.ovf",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'qcow2',
+ size => DEFAULT_SIZE,
+ volid => "local:import/some-disk.qcow2",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'vmdk',
+ size => DEFAULT_SIZE,
+ volid => "local:import/some-disk.vmdk",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'raw',
+ size => DEFAULT_SIZE,
+ volid => "local:import/some-raw-disk.raw",
+ },
+ ],
+ },
+ {
+ description => 'VMID: none, non-matching file paths for import',
+ vmid => undef,
+ files => [
+ # Malformed file names
+ "$storage_dir/import/import.ovff",
+ "$storage_dir/import/importova",
+ "$storage_dir/import/import.ov",
+ "$storage_dir/import/diskraw",
+ "$storage_dir/import/diskvmdk",
+ "$storage_dir/import/disk.invalid",
+ "$storage_dir/import/.ova",
+ "$storage_dir/import/.raw",
+ # Trailing whitespace must not be trimmed
+ "$storage_dir/import/import.ova\t",
+ "$storage_dir/import/disk.raw ",
+ # Whitespace in file name
+ "$storage_dir/import/something I want to import.ova",
+ "$storage_dir/import/ .raw",
+ "$storage_dir/import/ disk .vmdk",
+ "$storage_dir/import/disk .qcow2",
+ "$storage_dir/import/ import.ova",
+ # Unsafe characters in file name
+ "$storage_dir/import/linux🐧-vm.ova",
+ "$storage_dir/import/🐪perl-playground🐪.ova",
+ "$storage_dir/import/fish_<><_<><_<><.ova",
+ $storage_dir . '/import/C:\\\\Windows\\Path.ova',
+ # Content inside .ova files may only be specified as part
+ # of volume names, and may never appear when looked up as
+ # a file path
+ "$storage_dir/import/import.ova/disk.qcow2",
+ "$storage_dir/import/import.ova/disk.raw",
+ "$storage_dir/import/import.ova/disk.vmdk",
+ "$storage_dir/import/import.ova/disk.invalid",
+ ],
+ expected => [], # returns empty list
+ },
+ {
+ description => 'VMID: none, weird but valid file names for import',
+ vmid => undef,
+ files => [
+ "$storage_dir/import/import.ova.ova",
+ "$storage_dir/import/import.ova.ova.ova",
+ "$storage_dir/import/import.ova.ova.ova.ova",
+ "$storage_dir/import/ova.ova",
+ "$storage_dir/import/ova.ovf",
+ "$storage_dir/import/ova.vmdk",
+ "$storage_dir/import/raw.raw.qcow2",
+ "$storage_dir/import/raw.raw.qcow2.import.qcow2",
+ "$storage_dir/import/raw.raw.raw.your-boat.ova",
+ ],
+ expected => [
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/import.ova.ova",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/import.ova.ova.ova",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/import.ova.ova.ova.ova",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/ova.ova",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ovf',
+ size => DEFAULT_SIZE,
+ volid => "local:import/ova.ovf",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'vmdk',
+ size => DEFAULT_SIZE,
+ volid => "local:import/ova.vmdk",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'qcow2',
+ size => DEFAULT_SIZE,
+ volid => "local:import/raw.raw.qcow2",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'qcow2',
+ size => DEFAULT_SIZE,
+ volid => "local:import/raw.raw.qcow2.import.qcow2",
+ },
+ {
+ content => 'import',
+ ctime => DEFAULT_CTIME,
+ format => 'ova',
+ size => DEFAULT_SIZE,
+ volid => "local:import/raw.raw.raw.your-boat.ova",
+ },
+ ],
+ },
);
# provide static vmlist for tests
my $mock_cluster = Test::MockModule->new('PVE::Cluster', no_auto => 1);
$mock_cluster->redefine(get_vmlist => sub { return $mocked_vmlist; });
@@ -577,10 +743,14 @@ $mock_fsi->redefine(
return wantarray ? ($size, $format, $used, $parent, $ctime) : $size;
},
);
+my sub cmp_volinfo_by_volid {
+ return $a->{volid} cmp $b->{volid};
+}
+
my $plan = scalar @tests;
plan tests => $plan + 1;
{
# don't accidentally modify vmlist, see bug report
@@ -600,18 +770,18 @@ plan tests => $plan + 1;
);
}
{
my $sid = 'local';
- my $types = ['rootdir', 'images', 'vztmpl', 'iso', 'backup', 'snippets'];
+ my $types = [grep { $scfg->{content}->{$_} } keys $scfg->{content}->%*];
my @suffixes = ('qcow2', 'raw', 'vmdk', 'vhdx');
# run through test cases
foreach my $tt (@tests) {
my $vmid = $tt->{vmid};
my $files = $tt->{files};
- my $expected = $tt->{expected};
+ my $expected = [sort cmp_volinfo_by_volid $tt->{expected}->@*];
my $description = $tt->{description};
my $parent = $tt->{parent};
# prepare environment
my $num = 0; #parent disks
@@ -630,12 +800,14 @@ plan tests => $plan + 1;
run_command([@cmd]);
}
}
- my $got;
- eval { $got = PVE::Storage::Plugin->list_volumes($sid, $scfg, $vmid, $types) };
+ my $got = eval {
+ my $volume_list = PVE::Storage::Plugin->list_volumes($sid, $scfg, $vmid, $types);
+ return [sort cmp_volinfo_by_volid $volume_list->@*];
+ };
$got = $@ if $@;
is_deeply($got, $expected, $description) || diag(explain($got));
# clean up after each test case, otherwise
--
2.47.3
next prev parent reply other threads:[~2026-11-17 20:43 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 20:38 [PATCH manager/storage v3 00/51] Fix #2884: Implement Subdirectory Scanning for Dir-Based Storage Types Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 01/51] test: plugin tests: run tests with at most 4 jobs Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 02/51] plugin, common: remove superfluous use of =pod command paragraph Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 03/51] common: use Exporter module for PVE::Storage::Common Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 04/51] plugin: make get_subdir_files a proper subroutine and update style Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 05/51] plugin api: replace subdir helper methods with standalone functions Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 06/51] common: prevent autovivification in plugin_get_vtype_subdir helper Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 07/51] plugin: break up if-elsif chain into separate if-blocks Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 08/51] plugin: adapt get_subdir_files helper of list_volumes API method Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 09/51] plugin: update code style of list_volumes plugin " Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 10/51] plugin: use closure for obtaining raw volume data in list_volumes Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 11/51] plugin: use closure for inner loop logic " Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 12/51] storage: update code style in function path_to_volume_id Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 13/51] storage: break up if-elsif chain in path_to_volume_id Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 14/51] storage: heave vtype file path parsing logic inside loop into helper Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 15/51] storage: clean up code that was moved into helper in path_to_volume_id Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 16/51] api: status: move content type assert for up-/downloads into helper Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 17/51] api: status: use get_subdir helper method to get content directory Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 18/51] api: status: move up-/download file path parsing code into helper Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 19/51] api: status: simplify file content assertion logic for up-/download Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 20/51] test: guest import: add tests for PVE::GuestImport Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 21/51] tree-wide: introduce parsing module and replace usages of ISO_EXT_RE_0 Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 22/51] common: test: set up parser testing code, add tests for 'iso' vtype Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 23/51] tree-wide: replace usages of VZTMPL_EXT_RE_1 with parsing functions Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 24/51] tree-wide: replace usages of BACKUP_EXT_RE_2 " Max R. Carrara
2026-11-17 20:38 ` [PATCH pve-storage v3 25/51] tree-wide: replace usages of inline regexes for snippets with parsers Max R. Carrara
2026-11-17 20:38 ` Max R. Carrara [this message]
2026-11-17 20:38 ` [PATCH pve-storage v3 27/51] tree-wide: replace remaining usages of regexes for 'import' vtype Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 28/51] tree-wide: simplify recently refactored parsing logic Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 29/51] test: list volumes: reorganize and modernize test running code Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 30/51] test: list volumes: fix broken test checking for vmlist modifications Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 31/51] test: list volumes: introduce new format for test cases Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 32/51] test: list volumes: remove legacy code and migrate cases to new format Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 33/51] plugin: do not return volumes of undeclared content types anymore Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 34/51] plugin: correct comment in get_subdir_files helper Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 35/51] test: parse volname: modernize code Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 36/51] test: parse volname: adapt tests regarding 'import' volume type Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 37/51] test: parse volname: move VM disk test creation into separate block Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 38/51] test: parse volname: move backup file test creation into sep. block Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 39/51] test: parse volname: parameterize test case creation for some vtypes Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 40/51] test: volume id: modernize code Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 41/51] test: volume id: rename 'volname' test case parameter to 'file' Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 42/51] test: filesystem path: modernize code Max R. Carrara
2026-11-17 20:39 ` [PATCH pve-storage v3 43/51] plugin: list content directories without globbing Max R. Carrara
2026-11-18 9:12 ` [PATCH pve-storage v3 44/51] fix #2884: implement nested subdir scanning and support 'iso' vtype Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 45/51] fix #2884: support nested subdir scanning for 'vztmpl' volume type Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 46/51] fix #2884: support nested subdir scanning for 'snippets' vtype Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 47/51] test: add more tests for 'import' vtype & guard against nested subdirs Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 48/51] test: add tests guarding against subdir scanning for vtypes Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 49/51] storage: resolve images in content dir overrides ending with a slash Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-storage v3 50/51] bump the storage plugin API version Max R. Carrara
2026-11-18 9:14 ` [PATCH pve-manager v3 51/51] fix #2884: ui: storage: add field for 'max-scan-depth' property Max R. Carrara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117203953.913035-27-m.carrara@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.