all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 15/17] ui: node: san: list NVMe over Fabrics controllers
Date: Fri, 13 Nov 2026 04:04:43 +0100	[thread overview]
Message-ID: <20261113030541.1591528-16-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261113030541.1591528-1-t.lamprecht@proxmox.com>

Add a view below Node > SAN with the controllers of a node, one per
connected portal, their state and the storage they belong to, and the
host NQN of the node. A controller can be disconnected from there, for
example after its portal was removed from the storage. The node
refuses that for the last usable path of a namespace in use.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 www/manager6/Makefile                  |   1 +
 www/manager6/SANUtils.js               |   5 ++
 www/manager6/Utils.js                  |   1 +
 www/manager6/node/Config.js            |   9 +-
 www/manager6/node/NVMeOFControllers.js | 115 +++++++++++++++++++++++++
 5 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100644 www/manager6/node/NVMeOFControllers.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index ab4b85d0c..83fa225b7 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -252,6 +252,7 @@ JSSRC= 							\
 	node/ISCSITargets.js				\
 	node/LVM.js					\
 	node/LVMThin.js					\
+	node/NVMeOFControllers.js			\
 	node/SANLuns.js					\
 	node/StatusView.js				\
 	node/Subscription.js				\
diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js
index d61c74df4..8c3ddb8a2 100644
--- a/www/manager6/SANUtils.js
+++ b/www/manager6/SANUtils.js
@@ -78,6 +78,11 @@ Ext.define('PVE.SANUtils', {
             'logged-in': ['check-circle good', gettext('Connected')],
             recovering: ['exclamation-circle warning', gettext('Reconnecting')],
             'not-connected': ['times-circle faded', gettext('Not connected')],
+            live: ['check-circle good', gettext('Connected')],
+            connecting: ['exclamation-circle warning', gettext('Reconnecting')],
+            resetting: ['exclamation-circle warning', gettext('Reconnecting')],
+            deleting: ['times-circle faded', gettext('Disconnecting')],
+            'deleting (no IO)': ['times-circle faded', gettext('Disconnecting')],
         }[value];
         let [icon, label] = display ?? ['question-circle faded', value];
         return `<i class="fa fa-fw fa-${icon}"></i> ${Ext.htmlEncode(label)}`;
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 4a97358ac..55d5806d5 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -2251,6 +2251,7 @@ Ext.define('PVE.Utils', {
             lvmthinremove: ['Thinpool', gettext('Remove')],
             migrateall: ['', gettext('Bulk migrate VMs and Containers')],
             move_volume: ['CT', gettext('Move Volume')],
+            nvmedisconnect: ['NVMe-oF', gettext('Disconnect')],
             'pbs-download': ['VM/CT', gettext('File Restore Download')],
             pull_file: ['CT', gettext('Pull file')],
             push_file: ['CT', gettext('Push file')],
diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js
index d4a292d68..f3db4acba 100644
--- a/www/manager6/node/Config.js
+++ b/www/manager6/node/Config.js
@@ -360,7 +360,7 @@ Ext.define('PVE.node.Config', {
             );
         }
 
-        // the san-luns and iscsi reads accept either privilege
+        // the san-luns, iscsi and nvmeof reads accept either privilege
         if (caps.nodes['Sys.Audit'] || caps.storage['Datastore.Allocate']) {
             me.items.push(
                 {
@@ -376,6 +376,13 @@ Ext.define('PVE.node.Config', {
                     iconCls: 'fa fa-bullseye',
                     groups: ['san'],
                 },
+                {
+                    xtype: 'pveNVMeOFControllerList',
+                    title: 'NVMe over Fabrics',
+                    itemId: 'san-nvmeof',
+                    iconCls: 'fa fa-plug',
+                    groups: ['san'],
+                },
             );
         }
 
diff --git a/www/manager6/node/NVMeOFControllers.js b/www/manager6/node/NVMeOFControllers.js
new file mode 100644
index 000000000..93955442d
--- /dev/null
+++ b/www/manager6/node/NVMeOFControllers.js
@@ -0,0 +1,115 @@
+Ext.define('PVE.node.NVMeOFControllerList', {
+    extend: 'Ext.grid.Panel',
+    xtype: 'pveNVMeOFControllerList',
+    onlineHelp: 'storage_nvmeof',
+    emptyText: gettext('No NVMe over Fabrics controllers found'),
+    viewConfig: { enableTextSelection: true },
+    store: {
+        fields: ['controller', 'subsysnqn', 'portal', 'state', 'namespaces', 'used-by-storage'],
+        sorters: ['subsysnqn', 'portal'],
+    },
+    columns: [
+        { text: gettext('Controller'), dataIndex: 'controller', width: 100 },
+        {
+            text: gettext('Subsystem'),
+            dataIndex: 'subsysnqn',
+            flex: 5,
+            renderer: Ext.htmlEncode,
+        },
+        { text: gettext('Portal'), dataIndex: 'portal', width: 180, renderer: Ext.htmlEncode },
+        {
+            text: gettext('State'),
+            dataIndex: 'state',
+            width: 150,
+            renderer: PVE.SANUtils.renderState,
+        },
+        { text: gettext('Namespaces'), dataIndex: 'namespaces', width: 110 },
+        {
+            text: gettext('Storage'),
+            dataIndex: 'used-by-storage',
+            flex: 1,
+            renderer: Ext.htmlEncode,
+        },
+    ],
+
+    reload: function () {
+        let me = this;
+        let load = (path, success) =>
+            Proxmox.Utils.API2Request({
+                url: `/nodes/${me.nodename}/nvmeof/${path}`,
+                method: 'GET',
+                waitMsgTarget: me.getView(),
+                failure: (response) =>
+                    Proxmox.Utils.setErrorMask(me.getView(), response.htmlStatus),
+                success: (response) => !me.destroyed && success(response.result.data),
+            });
+        load('status', function (status) {
+            me.down('#hostnqn').setValue(status['host-nqn'] || '');
+            let error = status.supported
+                ? status.error
+                : gettext('nvme-cli is not installed on this node.');
+            if (error) {
+                Proxmox.Utils.setErrorMask(me.getView(), Ext.htmlEncode(error));
+                return;
+            }
+            load('controller', function (controllers) {
+                Proxmox.Utils.setErrorMask(me.getView(), false);
+                me.getStore().setData(controllers);
+            });
+        });
+    },
+
+    listeners: {
+        activate: function () {
+            this.reload();
+        },
+    },
+
+    initComponent: function () {
+        let me = this;
+        me.nodename = me.pveSelNode.data.node;
+        me.tbar = [
+            { text: gettext('Reload'), iconCls: 'fa fa-refresh', handler: () => me.reload() },
+            {
+                xtype: 'proxmoxButton',
+                text: gettext('Disconnect'),
+                iconCls: 'fa fa-unlink',
+                disabled: true,
+                dangerous: true,
+                enableFn: () => !!Ext.state.Manager.get('GuiCap').dc['Sys.Modify'],
+                confirmMsg: (rec) =>
+                    Ext.String.format(
+                        gettext(
+                            'Disconnect controller {0}? A storage that still lists its portal connects to it again.',
+                        ),
+                        Ext.htmlEncode(rec.get('controller')),
+                    ),
+                handler: (button, event, rec) =>
+                    Proxmox.Utils.API2Request({
+                        url: `/nodes/${me.nodename}/nvmeof/controller/${rec.get('controller')}`,
+                        method: 'DELETE',
+                        waitMsgTarget: me,
+                        failure: (response) => Ext.Msg.alert(gettext('Error'), response.htmlStatus),
+                        success: (response) =>
+                            Ext.create('Proxmox.window.TaskProgress', {
+                                upid: response.result.data,
+                                autoShow: true,
+                                taskDone: () => !me.destroyed && me.reload(),
+                            }),
+                    }),
+            },
+            '->',
+            {
+                xtype: 'displayfield',
+                itemId: 'hostnqn',
+                fieldLabel: gettext('Host NQN'),
+            },
+            {
+                iconCls: 'fa fa-clipboard',
+                tooltip: gettext('Copy to Clipboard'),
+                handler: () => PVE.Utils.copyToClipboard(me.down('#hostnqn').getValue()),
+            },
+        ];
+        me.callParent();
+    },
+});




  parent reply	other threads:[~2026-11-13  3:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13  3:04 [PATCH storage,docs,manager 00/17] NVMe over Fabrics storage Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 01/17] diskmanage: skip SMART queries for NVMe fabric namespaces Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 02/17] nvmeof: add a storage for NVMe over Fabrics subsystems Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 03/17] lvm: allow a volume group on an NVMe over Fabrics namespace Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 04/17] api: scan: add NVMe over Fabrics discovery Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 05/17] pvesm: add a scan command for NVMe over Fabrics Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 06/17] api: scan: san-luns: attribute NVMe namespaces to storage Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 07/17] api: add node-level NVMe over Fabrics status and controller removal Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 08/17] multipath: report the NVMe host NQN of each node Thomas Lamprecht
2026-11-13  3:04 ` [PATCH storage 09/17] multipath: report NVMe over Fabrics namespaces in the cluster status Thomas Lamprecht
2026-11-13  3:04 ` [PATCH docs 10/17] storage: document NVMe over Fabrics storages Thomas Lamprecht
2026-11-13  3:04 ` [PATCH manager 11/17] api: nodes: mount the NVMe over Fabrics endpoints Thomas Lamprecht
2026-11-13  3:04 ` [PATCH manager 12/17] ui: storage: add NVMe over Fabrics storage Thomas Lamprecht
2026-11-13  3:04 ` [PATCH manager 13/17] ui: lvm: offer NVMe over Fabrics storages as base storage Thomas Lamprecht
2026-11-13  3:04 ` [PATCH manager 14/17] ui: dc: san: add a guided setup for shared LVM on NVMe over Fabrics Thomas Lamprecht
2026-11-13  3:04 ` Thomas Lamprecht [this message]
2026-11-13  3:04 ` [PATCH manager 16/17] ui: dc: san: show the NVMe host NQN of each node Thomas Lamprecht
2026-11-13  3:04 ` [PATCH manager 17/17] ui: dc: san: show that a namespace uses native multipath Thomas Lamprecht
2026-11-18 20:44 ` superseded: [PATCH storage,docs,manager 00/17] NVMe over Fabrics storage Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261113030541.1591528-16-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal