From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager 12/17] ui: storage: add NVMe over Fabrics storage
Date: Fri, 13 Nov 2026 04:04:40 +0100 [thread overview]
Message-ID: <20261113030541.1591528-13-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261113030541.1591528-1-t.lamprecht@proxmox.com>
Show storages of the new type with their subsystem in the storage list
and add their dialog. Adding one lists the subsystems a discovery
portal reports and fills in the portals of the selected one, which can
be changed. Portals, nodes, content and the fast I/O fail timeout can
be edited later.
The subsystem selector builds on the iSCSI target selector, whose
store fields and sort key a subclass can now set.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 6 ++
www/manager6/dc/StorageView.js | 5 +-
www/manager6/storage/IScsiEdit.js | 5 +-
www/manager6/storage/NVMeOFEdit.js | 127 +++++++++++++++++++++++++++++
5 files changed, 141 insertions(+), 3 deletions(-)
create mode 100644 www/manager6/storage/NVMeOFEdit.js
diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index ebdc3f802..fbd866b4b 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -377,6 +377,7 @@ JSSRC= \
storage/LvmThinEdit.js \
storage/BTRFSEdit.js \
storage/NFSEdit.js \
+ storage/NVMeOFEdit.js \
storage/PBSEdit.js \
storage/RBDEdit.js \
storage/StatusView.js \
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 865ba44ff..4a97358ac 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -869,6 +869,12 @@ Ext.define('PVE.Utils', {
faIcon: 'building',
backups: false,
},
+ nvmeof: {
+ name: 'NVMe over Fabrics',
+ ipanel: 'NVMeOFInputPanel',
+ faIcon: 'building',
+ backups: false,
+ },
cephfs: {
name: 'CephFS',
ipanel: 'CephFSInputPanel',
diff --git a/www/manager6/dc/StorageView.js b/www/manager6/dc/StorageView.js
index 54fbde711..4fc49f5cd 100644
--- a/www/manager6/dc/StorageView.js
+++ b/www/manager6/dc/StorageView.js
@@ -128,7 +128,9 @@ Ext.define(
sortable: true,
dataIndex: 'path',
renderer: function (value, metaData, record) {
- return Ext.htmlEncode(record.data.target || value);
+ return Ext.htmlEncode(
+ record.data.target || record.data.subsysnqn || value,
+ );
},
},
{
@@ -171,6 +173,7 @@ Ext.define(
'server',
'portal',
'target',
+ 'subsysnqn',
'export',
'storage',
{ name: 'shared', type: 'boolean' },
diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js
index f11995585..83d31017f 100644
--- a/www/manager6/storage/IScsiEdit.js
+++ b/www/manager6/storage/IScsiEdit.js
@@ -5,6 +5,7 @@ Ext.define('PVE.storage.IScsiScan', {
queryParam: 'portal',
valueField: 'target',
displayField: 'target',
+ scanFields: ['target', 'portal'],
matchFieldWidth: false,
allowBlank: false,
@@ -53,13 +54,13 @@ Ext.define('PVE.storage.IScsiScan', {
}
let store = Ext.create('Ext.data.Store', {
- fields: ['target', 'portal'],
+ fields: me.scanFields,
proxy: {
type: 'proxmox',
url: `${me.apiBaseUrl}${me.nodename}${me.apiSuffix}`,
},
});
- store.sort('target', 'ASC');
+ store.sort(me.valueField, 'ASC');
Ext.apply(me, {
store: store,
diff --git a/www/manager6/storage/NVMeOFEdit.js b/www/manager6/storage/NVMeOFEdit.js
new file mode 100644
index 000000000..92057dc4f
--- /dev/null
+++ b/www/manager6/storage/NVMeOFEdit.js
@@ -0,0 +1,127 @@
+Ext.define('PVE.storage.NVMeOFScan', {
+ extend: 'PVE.storage.IScsiScan',
+ alias: 'widget.pveNVMeOFScan',
+
+ valueField: 'subsysnqn',
+ displayField: 'subsysnqn',
+ scanFields: ['subsysnqn', 'portals'],
+ showNodeSelector: false,
+
+ listConfig: {
+ width: 650,
+ columns: [
+ {
+ dataIndex: 'subsysnqn',
+ flex: 1,
+ renderer: Ext.htmlEncode,
+ },
+ ],
+ emptyText: PVE.Utils.renderNotFound(gettext('Subsystem')),
+ },
+
+ config: {
+ apiSuffix: '/scan/nvmeof',
+ },
+});
+
+Ext.define('PVE.storage.NVMeOFInputPanel', {
+ extend: 'PVE.panel.StorageBase',
+ mixins: ['Proxmox.Mixin.CBind'],
+
+ onlineHelp: 'storage_nvmeof',
+
+ onGetValues: function (values) {
+ let me = this;
+
+ values.content = values.namespaces ? 'images' : 'none';
+ delete values.namespaces;
+
+ return me.callParent([values]);
+ },
+
+ setValues: function (values) {
+ values.namespaces = values.content.indexOf('images') !== -1;
+ this.callParent([values]);
+ },
+
+ column1: [
+ {
+ xtype: 'textfield',
+ name: 'discovery-portal',
+ fieldLabel: gettext('Discovery Portal'),
+ allowBlank: false,
+ submitValue: false,
+ cbind: {
+ hidden: '{!isCreate}',
+ disabled: '{!isCreate}',
+ },
+ listeners: {
+ change: {
+ fn: function (field, value) {
+ let scan = this.up('inputpanel').lookup('subsystemScan');
+ scan.setDisabled(!value);
+ scan.setPortal(value);
+ scan.setValue('');
+ },
+ buffer: 500,
+ },
+ },
+ },
+ {
+ xtype: 'checkbox',
+ name: 'namespaces',
+ boxLabel: gettext('Use namespaces directly'),
+ },
+ ],
+
+ // NQNs and portal lists are longer than a column is wide
+ columnB: [
+ {
+ cbind: {
+ xtype: (get) => (get('isCreate') ? 'pveNVMeOFScan' : 'displayfield'),
+ disabled: '{isCreate}',
+ },
+ name: 'subsysnqn',
+ value: '',
+ fieldLabel: gettext('Subsystem'),
+ allowBlank: false,
+ reference: 'subsystemScan',
+ listeners: {
+ change: function (field, value) {
+ let rec = field
+ .getStore?.()
+ .findRecord('subsysnqn', value, 0, false, true, true);
+ if (rec) {
+ field
+ .up('inputpanel')
+ .down('field[name=nvme-portals]')
+ .setValue(rec.get('portals'));
+ }
+ },
+ },
+ },
+ {
+ xtype: 'textfield',
+ name: 'nvme-portals',
+ fieldLabel: gettext('Portals'),
+ allowBlank: false,
+ },
+ ],
+
+ advancedColumn1: [
+ {
+ xtype: 'proxmoxintegerfield',
+ name: 'nvme-fast-io-fail-tmo',
+ fieldLabel: gettext('Fail I/O After (s)'),
+ minValue: -1,
+ emptyText: '120',
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext('Applies to newly connected paths. -1 disables the timeout.'),
+ },
+ },
+ ],
+});
next prev parent reply other threads:[~2026-11-13 3:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 3:04 [PATCH storage,docs,manager 00/17] NVMe over Fabrics storage Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 01/17] diskmanage: skip SMART queries for NVMe fabric namespaces Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 02/17] nvmeof: add a storage for NVMe over Fabrics subsystems Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 03/17] lvm: allow a volume group on an NVMe over Fabrics namespace Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 04/17] api: scan: add NVMe over Fabrics discovery Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 05/17] pvesm: add a scan command for NVMe over Fabrics Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 06/17] api: scan: san-luns: attribute NVMe namespaces to storage Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 07/17] api: add node-level NVMe over Fabrics status and controller removal Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 08/17] multipath: report the NVMe host NQN of each node Thomas Lamprecht
2026-11-13 3:04 ` [PATCH storage 09/17] multipath: report NVMe over Fabrics namespaces in the cluster status Thomas Lamprecht
2026-11-13 3:04 ` [PATCH docs 10/17] storage: document NVMe over Fabrics storages Thomas Lamprecht
2026-11-13 3:04 ` [PATCH manager 11/17] api: nodes: mount the NVMe over Fabrics endpoints Thomas Lamprecht
2026-11-13 3:04 ` Thomas Lamprecht [this message]
2026-11-13 3:04 ` [PATCH manager 13/17] ui: lvm: offer NVMe over Fabrics storages as base storage Thomas Lamprecht
2026-11-13 3:04 ` [PATCH manager 14/17] ui: dc: san: add a guided setup for shared LVM on NVMe over Fabrics Thomas Lamprecht
2026-11-13 3:04 ` [PATCH manager 15/17] ui: node: san: list NVMe over Fabrics controllers Thomas Lamprecht
2026-11-13 3:04 ` [PATCH manager 16/17] ui: dc: san: show the NVMe host NQN of each node Thomas Lamprecht
2026-11-13 3:04 ` [PATCH manager 17/17] ui: dc: san: show that a namespace uses native multipath Thomas Lamprecht
2026-11-18 20:44 ` superseded: [PATCH storage,docs,manager 00/17] NVMe over Fabrics storage Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113030541.1591528-13-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.