From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v5 0/4] hotplug: improve and fix cleanup/error handling
Date: Fri, 30 Oct 2026 11:04:39 +0100 [thread overview]
Message-ID: <20261030101134.2090350-1-d.csapak@proxmox.com> (raw)
This replaces my earlier v4 9/9 patch[0]
It uses a different approach now by unifying the cleanup and removal of
disks and their controllers.
It also fixes a related bug in 1/4 that was uncovered.
changes from v4:
* rebase on master
* new bugfix (1/4)
* new patch for iothread deletion
* new patch for refactoring the cleanup
0: https://lore.proxmox.com/pve-devel/20261023130324.451252-10-d.csapak@proxmox.com/
Dominik Csapak (4):
hotplug: scsi: only keep controller if a disk on it is still present
hotplug: remove iothread with virtio-scsi controller together
hotplug: factor out cleanup of disk devices
hotplug: clean up disk devices/objects if adding them failed
src/PVE/QemuServer.pm | 107 ++++++++++--------
src/test/hotplug/disk-add-fail.conf | 19 ++++
src/test/hotplug/disk-add-fail.conf.expected | 10 ++
.../disk-add-scsi-single-disk-fail.conf | 19 ++++
...sk-add-scsi-single-disk-fail.conf.expected | 12 ++
.../hotplug/disk-add-scsi-single-fail.conf | 19 ++++
.../disk-add-scsi-single-fail.conf.expected | 5 +
.../hotplug/disk-remove-lsi-last-slot.conf | 16 +++
.../disk-remove-lsi-last-slot.conf.expected | 3 +
.../disk-remove-lsi-second-controller.conf | 16 +++
...remove-lsi-second-controller.conf.expected | 4 +
11 files changed, 183 insertions(+), 47 deletions(-)
create mode 100644 src/test/hotplug/disk-add-fail.conf
create mode 100644 src/test/hotplug/disk-add-fail.conf.expected
create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf
create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf.expected
create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf
create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf.expected
create mode 100644 src/test/hotplug/disk-remove-lsi-last-slot.conf
create mode 100644 src/test/hotplug/disk-remove-lsi-last-slot.conf.expected
create mode 100644 src/test/hotplug/disk-remove-lsi-second-controller.conf
create mode 100644 src/test/hotplug/disk-remove-lsi-second-controller.conf.expected
--
2.47.3
next reply other threads:[~2026-10-30 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 10:04 Dominik Csapak [this message]
2026-10-30 10:04 ` [PATCH qemu-server v5 1/4] hotplug: scsi: only keep controller if a disk on it is still present Dominik Csapak
2026-10-30 10:04 ` [PATCH qemu-server v5 2/4] hotplug: remove iothread with virtio-scsi controller together Dominik Csapak
2026-10-30 10:04 ` [PATCH qemu-server v5 3/4] hotplug: factor out cleanup of disk devices Dominik Csapak
2026-10-30 10:04 ` [PATCH qemu-server v5 4/4] hotplug: clean up disk devices/objects if adding them failed Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261030101134.2090350-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.