[PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree

[PATCH pve-manager] fix #5001: ui: add context menu with bulk actions for pools in resource tree

[Jonas Theisen]

The pool view groups guests by their pool, but unlike the tag view it
offers no context menu on the pool tree-node itself. Add one with the
same guest bulk actions as the datacenter and tag menus.

The bulk action window opens with the pool filter pre-selected for the
pool the menu was opened on. Only guests that are direct members of
that pool are selected, guests in nested sub-pools are not, matching
how the pool filter works when set manually.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=5001
Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/manager6/Utils.js             |  4 ++++
 www/manager6/dc/CmdMenu.js        | 26 ++++++++++++++++++++++++++
 www/manager6/window/BulkAction.js |  3 +++
 3 files changed, 33 insertions(+)

diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index 8b99371d..ced25763 100644
--- a/www/manager6/Utils.js
+++ b/www/manager6/Utils.js
@@ -1630,6 +1630,10 @@ Ext.define('PVE.Utils', {
                 menu = Ext.create('PVE.dc.TagCmdMenu', {
                     tag: record.data.tag,
                 });
+            } else if (type === 'pool') {
+                menu = Ext.create('PVE.dc.PoolCmdMenu', {
+                    pool: record.data.pool,
+                });
             } else if (record?.isRoot()) {
                 menu = Ext.create('PVE.dc.CmdMenu', {
                     pveSelNode: record,
diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
index 5bb4d7d1..f47132ee 100644
--- a/www/manager6/dc/CmdMenu.js
+++ b/www/manager6/dc/CmdMenu.js
@@ -127,3 +127,29 @@ Ext.define('PVE.dc.TagCmdMenu', {
         me.callParent();
     },
 });
+
+Ext.define('PVE.dc.PoolCmdMenu', {
+    extend: 'PVE.dc.CmdMenu',
+    xtype: 'poolCmdMenu',
+
+    minWidth: 220,
+
+    initComponent: function () {
+        let me = this;
+
+        if (!me.pool) {
+            throw 'no pool specified';
+        }
+
+        me.title = `${gettext('Pool')} '${me.pool}'`;
+        if (PVE.ClusterName?.length) {
+            me.title += ` (${PVE.ClusterName})`;
+        }
+
+        me.extraHandlerArgs = {
+            prefilterPool: me.pool,
+        };
+
+        me.callParent();
+    },
+});
diff --git a/www/manager6/window/BulkAction.js b/www/manager6/window/BulkAction.js
index 2e3066a3..7e58fb3f 100644
--- a/www/manager6/window/BulkAction.js
+++ b/www/manager6/window/BulkAction.js
@@ -557,6 +557,9 @@ Ext.define('PVE.window.BulkAction', {
         if (me.prefilterIncludeTag) {
             me.down('#includetagfilter').setValue(me.prefilterIncludeTag);
         }
+        if (me.prefilterPool) {
+            me.down('#poolfilter').setValue(me.prefilterPool);
+        }
 
         form.on('validitychange', function () {
             let valid = form.isValid();
-- 
2.47.3

[PATCH pve-manager] ui: tag menu: show cluster name instead of undefined in title

[Jonas Theisen]

The tag context menu appends the node name to its title if a cluster
name is set, but no node name is ever passed to it, so clustered
setups show "(undefined)". Use the cluster name instead, like the
datacenter context menu does.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/manager6/dc/CmdMenu.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/CmdMenu.js b/www/manager6/dc/CmdMenu.js
index 87671adb..5bb4d7d1 100644
--- a/www/manager6/dc/CmdMenu.js
+++ b/www/manager6/dc/CmdMenu.js
@@ -117,7 +117,7 @@ Ext.define('PVE.dc.TagCmdMenu', {
 
         me.title = `${gettext('Tag')} '${me.tag}'`;
         if (PVE.ClusterName?.length) {
-            me.title += ` (${me.nodename})`;
+            me.title += ` (${PVE.ClusterName})`;
         }
 
         me.extraHandlerArgs = {
-- 
2.47.3