all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH ha-manager 1/2] rules: fix call to parent classes register() method
Date: Mon, 19 Oct 2026 15:36:21 +0200	[thread overview]
Message-ID: <20261019133754.177328-2-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261019133754.177328-1-f.ebner@proxmox.com>

In the rules base plugin's register() method, the $class variable is
passed along twice to the SectionConfig's register() implementation,
which only takes a single argument. Fix it now to avoid future
fallout, if the number of arguments becomes enforced via signatures or
before a second argument is added, where this would cause problems.

Fixes: 433ed1a ("introduce rules base plugin")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/HA/Rules.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm
index a0a1041..14836f4 100644
--- a/src/PVE/HA/Rules.pm
+++ b/src/PVE/HA/Rules.pm
@@ -297,7 +297,7 @@ my $transformdef;
 sub register {
     my ($class) = @_;
 
-    $class->SUPER::register($class);
+    $class->SUPER::register();
 
     # store order in which plugin types are registered
     push @$types, $class->type();
-- 
2.47.3





  reply	other threads:[~2026-10-19 13:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 13:36 [PATCH-SERIES ha-manager/common 0/2] rules: fix call to parent class' register() method Fiona Ebner
2026-10-19 13:36 ` Fiona Ebner [this message]
2026-10-19 13:36 ` [PATCH common 2/2] section config: register: add note about potential ha-manager breakage Fiona Ebner
2026-10-19 20:31 ` applied: [PATCH-SERIES ha-manager/common 0/2] rules: fix call to parent class' register() method Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261019133754.177328-2-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal