From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AC1371FF09C for ; Mon, 19 Oct 2026 15:38:15 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7D83721649; Mon, 19 Oct 2026 15:38:03 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager 1/2] rules: fix call to parent classes register() method Date: Mon, 19 Oct 2026 15:36:21 +0200 Message-ID: <20261019133754.177328-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261019133754.177328-1-f.ebner@proxmox.com> References: <20261019133754.177328-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792417078230 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.381 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ARY6X3BB7MF3R4I62EDQMAQ5BKF7R7OH X-Message-ID-Hash: ARY6X3BB7MF3R4I62EDQMAQ5BKF7R7OH X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In the rules base plugin's register() method, the $class variable is passed along twice to the SectionConfig's register() implementation, which only takes a single argument. Fix it now to avoid future fallout, if the number of arguments becomes enforced via signatures or before a second argument is added, where this would cause problems. Fixes: 433ed1a ("introduce rules base plugin") Signed-off-by: Fiona Ebner --- src/PVE/HA/Rules.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm index a0a1041..14836f4 100644 --- a/src/PVE/HA/Rules.pm +++ b/src/PVE/HA/Rules.pm @@ -297,7 +297,7 @@ my $transformdef; sub register { my ($class) = @_; - $class->SUPER::register($class); + $class->SUPER::register(); # store order in which plugin types are registered push @$types, $class->type(); -- 2.47.3